On Sep 24, 2011, at 10:00 AM, Tudor Girba wrote:
Hi,
On 23 Sep 2011, at 22:15, Stéphane Ducasse wrote:
Hi guys
Is there a reason why we get #Attribute and not FAMIXAttribute
I do not understand. Do you refer to the name of the MetaDescription? If yes, that is because the qualified name is 'FAMIX.Attribute', given that it belongs to the FAMIX package. So, there is no need to prefix the class name.
and/or super: #FAMIXStructuredEntity instead of
super: 'FAMIX.StructuredEntity'Ok, this is pretty much crappy :). #FAMIXStructuredEntity will perform a lookup of the class in the Smalltalk image. 'FAMIX.StructuredEntity' will perform it in the Fame meta repository. We should only use symbols because they are also affected by refactorings. I will create a rule :).
I do not get it. Why two different lookup for a single position argument because we jhave in the image
<MSEClass: #Attribute super: 'FAMIX.StructuralEntity'> and <MSEClass: #Association super: #FAMIXSourcedEntity>
And to me super: is the same kind of lookup not two.
So I would prefer to have something regular either
#'FAMIX.Attribute' super: #'FAMIX.StructuredEntity' or #Attribute super: #StructuredEntity
In fact I would prefer
#'FAMIXAttribute' super: #'FAMIXStructuredEntity
No. It should be: MSEClass: 'Attribute' super: #FAMIXStructuralEntity
I try to understand what you meant
If FAMIXStructuralEntity is to look up the FMClass in the metatower and look for the MSEClass: 'StructuralEntity' super: #Whatwever
Then I do not get why it should be #FAMIXStructuralEntity MSEClass: 'Attribute' super: #FAMIXStructuralEntity
and not MSEClass: 'Attribute' super: #StructuralEntity
Finally I do not get the need to have FAMIX in front of the second one because it looks like you hardocde in the anme the package and this is not nice and looks bad
MSEClass: #Attribute# super: #StructuralEntity package: #FAMIX
would be better to me.
Then I do not see why you have a string and a symbol this makes everything more complex
MSEClass: 'Attribute' super: #FAMIXStructuralEntity
So MSEClass: 'Attribute' super: #FAMIXStructuralEntity does not satisfy me So tell me and we fix it but once for all.
Stef