On Aug 10, 2013, at 10:03 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote:
Ok, I see the problem now, although is not
reproducible in the case of ConfigurationOfMoose simply because of the load order I think.
But, the bug was clearly present.
I looked at your code and it fixed the problem. However, I now took a step back and I
realize that we are working on the wrong model :). All the information we need is in the
working copies, so I removed all intermediary string-based collections and I am only using
a collection of working copies. It seems to work fine. I pushed it as stable. Could you
have a look?
I will.
Now I wonder why we worked with string (probably because at the beginning I got only
strings that I save between images) - since I made a diff.
Cheers,
Doru
On Sat, Aug 10, 2013 at 6:14 PM, Stéphane Ducasse <stephane.ducasse(a)inria.fr>
wrote:
Gofer new
smalltalkhubUser: 'girba' project: 'Snapshotcello';
package: 'ConfigurationOfSnapshotcello';
load.
ConfigurationOfSnapshotcello loadStable.
Snapshotcello new
configurationClass: ConfigurationOfMoose;
sourceVersion: #development;
repositoryFor: 'ConfigurationOfMooseAlgos'
==> 'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'
doru
I just checked because you put a doubt in my mind but I was right
repositoryFor: is for versioned package not package names
so the real case (in fact I put a transcript while snapshotting Moose) is
Snapshotcello new
configurationClass: ConfigurationOfMoose;
sourceVersion: #development;
repositoryFor: 'ConfigurationOfFame-TudorGirba.19'
With Snapshotcello 20
Snapshotcello new
configurationClass: ConfigurationOfFourDBrowser;
sourceVersion: #development;
repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.34'
>>
'http://www.smalltalkhub.com/mc/Moose/Moose/main/'
With Snapshotcello 23 (my favorite solution but I need your look)
Snapshotcello new
configurationClass: ConfigurationOfFourDBrowser;
sourceVersion: #development;
repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.34'
>>
'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'
With Snapshotcello21 (improving the match to cut at '-')
Snapshotcello new
configurationClass: ConfigurationOfFourDBrowser;
sourceVersion: #development;
repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.34'
'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'
I was afraid that my changes was just fixing the consequences of a problem in the method
computePackagesAndRepositoriesFromConfiguration
but it is correct. What metacello gives us back is a correct list of pairs.
Stef
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"Every thing has its own flow"
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev