Hi Esteban,
Please go ahead and commit always - that is why it is open to commit. Then we review and
we figure out if it is what we want :)
Cheers,
Doru
On 17 Apr 2012, at 21:10, Esteban Lorenzano wrote:
Hi,
I have some minimal glamour enhancements that I would like to push up. Not too important,
but I would like to hear opinions before commiting:
1) GLMAction refactoring
-I added several testing methods (#isMenu, #isButton)
-I changed way of rendering actions, adding a #renderGlamorouslyOn: inside actions (so
you can change ways of presenting action buttons if desired: I needed to add some behavior
for my customer of lawsuit tracker)
-refactor #renderToolbarForPresentation:inMorph: to take advantage of all this issues.
2) morph presentation refactoring
It was showing a plain morph, I added a renderer to be able to respond to events fired by
updateOn:
3) actionList presentation was refactored into it's own renderer... yes, I know Doru
wants to drop that presentation, but I needed then I added it (if you want to drop this
one, I can put it in my own package)
4) I added icons and shortcut text to context menus (if present... if not, everything
behaves like before)
all tests are green
so... should I push this changes?
best,
Esteban
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"To lead is not to demand things, it is to make them happen."