[Moose-dev] Re: RPackage issue ?

On May 7, 2011, at 10:49 PM, Cyrille Delaunay wrote: > The bug appeared when removing two extensions methods (from the same extending package) for a same class. > in RPackage >> removeMethod: , when removing an extension method, we were telling the organizer to remove the extending package for the class concerned. This was wrong, because even if one extension from this package has been removed, some others can still exist. And the organizer should keep the this package as extending package for the class. > So removing the first extension method worked correctly, but then removing a second or more methods from the same package was raising some errors Thanks we should write a test for that. Stef > > 2011/5/7 Tudor Girba <tudor.girba(a)gmail.com> > Hi, > > Could you tell us what the bug was? It would be good to know just in case in the future we encounter something similar. > > Cheers, > Doru > > > On 7 May 2011, at 16:51, Cyrille Delaunay wrote: > >> Yes I fixed the bug. just left to modify the version of RPackage to load the correct version of the modified package. I think stephane will do it while looking at my changes. >> >> 2011/5/7 Stéphane Ducasse <stephane.ducasse(a)inria.fr> >> >> On May 7, 2011, at 11:59 AM, Tudor Girba wrote: >> >>> Stef, you told us to load #stable and this is what we are loading, and currently #stable loads '1.0'. >> >> ok good then >> >>> That is why I asked on the Pharo mailing list if 3.0 is stable, so that #stable should point to it rather than to '1.0'. >> >> ah ok yes I think that it is more stable >> >>> If you want this versioning scheme to work, you have to take into account the energy to maintain the configuration. Otherwise, feedback will always be out of date, and the dialog not very constructive. >> >> Yes I maintain it do not worry. >> >>> >>> However, I did some more tests and it seems that some desynchronization appears in 3.0 as well, only I do not know how to reproduce the problem because I do not know where it comes from. >> >> Ok >> I would like to know that too. >> >>> Cyrille, could you detail your finding for documentation purpose? >>> >>> Cheers, >>> Doru >>> >>> >>> On 7 May 2011, at 11:49, Stéphane Ducasse wrote: >>> >>>> I do not get it. >>>> Don't you use the 3.0 version? >>>> Because I do not know what is the 1.0 especially since you loaded latest so this measn that I have no clue >>>> what version is really loaded and I will not have a look because I cannot spend time reverse engineer >>>> working set of packages. >>>> We started to sync with cyrille yesterday and I will merge his changes and produce a new 3.0 and a stable tag. >>>> So that people can load stable and we can continue to work on the integration. >>>> >>>> Stef >>>> On May 7, 2011, at 11:21 AM, Tudor Girba wrote: >>>> >>>>> The issue is that the Organizer gets out of sync. I do not know when, but I saw it happening. It is what I sent to the pharo mailing list: >>>>> >>>>> ---quote--- >>>>> >>>>> ConfigurationOfRPackage 1.0 seems to go out of sync with the image after a while. For example, download the following Moose image: >>>>> http://hudson.moosetechnology.org/job/moose-latest-dev/lastSuccessfulBuild/… >>>>> >>>>> and try >>>>> RPackage organizer packageNamed: 'Famix-Core' >>>>> >>>>> --- >>>>> >>>>> Cheers, >>>>> Doru >>>>> >>>>> On 7 May 2011, at 11:15, Stéphane Ducasse wrote: >>>>> >>>>>> >>>>>> On May 6, 2011, at 3:25 PM, jannik.laval wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I think to have a bug with RPackage. >>>>>>> >>>>>>> I used MooseScripts>>createModelForMoose. >>>>>>> This method works fine. >>>>>>> >>>>>>> then I removed 3 methods useless for Moose (see issue 614) >>>>>>> >>>>>>> When I rerun MooseScripts>>createModelForMoose, there is an error key not found. >>>>>>> The cache of RPackage is not updated. >>>>>> >>>>>> what cache? >>>>>>> >>>>>>> Any solution ? >>>>>>> >>>>>>> Jannik >>>>>>> _______________________________________________ >>>>>>> Moose-dev mailing list >>>>>>> Moose-dev(a)iam.unibe.ch >>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Moose-dev mailing list >>>>>> Moose-dev(a)iam.unibe.ch >>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>>> >>>>> -- >>>>> www.tudorgirba.com >>>>> >>>>> "From an abstract enough point of view, any two things are similar." >>>>> >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Moose-dev mailing list >>>>> Moose-dev(a)iam.unibe.ch >>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>> >>>> >>>> _______________________________________________ >>>> Moose-dev mailing list >>>> Moose-dev(a)iam.unibe.ch >>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>> >>> -- >>> www.tudorgirba.com >>> >>> "Sometimes the best solution is not the best solution." >>> >>> >>> _______________________________________________ >>> Moose-dev mailing list >>> Moose-dev(a)iam.unibe.ch >>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > -- > www.tudorgirba.com > > "Every now and then stop and ask yourself if the war you're fighting is the right one." > > > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev