edges: aCollection from: aFromBlock "- aCollection is the collection of edges to represent.
- aFromBlock will be called on each element of the collection and return one edge source each time.
Note that there is no restriction on the elements of aCollection, as long as aFromBlock returns a node. "
aCollection is a bad name for an argument.
I agree. It should be aCollectionOfEntities.
I renamed "aCollection" into "aCollectionOfEntities" in all the edges:* methods. I also replace "aCollection is the collection of edges to represent." by " aCollectionOfEntities is the collection of from which the edges are defined from."
Now in Version 2.107 of Mondrian
Cheers, Alexandre
Same here..... even if this is a bit better because there is one example showing that the comment is not wrong.
edges: aCollection from: aFromBlock toAll: aToBlock "- aCollection is the collection of edges to represent.
- aFromBlock will be called on each element of the collection and return one edge source each time.
- aToBlock will be called similarly to return a collection of destination correpsonding to each source.
Note that there is no restriction on the elements of aCollection, as long as aFromBlock returns a node and aToBlock returns a collection of nodes. For example: aView edges: someFamixInvocations from: #sender toAll: #candidates
aToBlock should return a collection, edges will be drawn from the element returned by aFromBlock to this collection"
^self edges: aCollection from: aFromBlock toAll: aToBlock using: self edgeShape
Again, the comment needs to be fixed.
Does this clarify the situation?
Doru
Stef _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"What is more important: To be happy, or to make happy?"
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev