Ok, then it's decided :).
Yes I should have checked before. I will fix then the merging and add the sharedVariable
(indeed, we implemented class scope for attributes and methods from the class side when Adrian redid the importer)
Doru
On Nov 8, 2008, at 10:00 AM, Stéphane Ducasse wrote:
So I will reask my original question: annotated with stress and tests results so far.
I will implement the following and I would like to let you know so that you can give feedback
======= case one: when we do not merge a class and its metaclass the instance variable of a metaclass could have an instanceScope since it is true that the instance variable is an instance one.
(I checked in moose and class inst variable have a class scope in this situation. So we probably got this discussion long time ago.)
======= case two: Now when we merge a class and its metaclass, the class instance variable should have a class scope since from the base class it is clearly a class scope variable. (this is what we have in moose right now)
For shared this is simple they are shared and have a classScope.
Now from a user point of view I would like that an analysis does not depend on whether we merged or not the class and metaclass **from the instance variable scope point of view** -- Of course the analysis like system complexity depends on the merge or not, there is no magic--
So I will put classScope to instance variable of the metaclass even when they are not merged with the base class. (in fact I checked and this is already the case in current Moose implementation)
This way we always get the following situation
instance varaible -> instanceScope class instance variable -> classScope shared -> classScope + isShared
Let me know what you think since I will implement the following and write tests. (apparently this is already implemented like that more or less). So I will add some tests in SqMoose and port them to VWMoose with sharedVariableSupport (later for now I will focus on SqMoose).
Stef _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com www.tudorgirba.com/blog
"Presenting is storytelling."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev