[Moose-dev] Re: [Roassal2] Events forwarding pressed modifier keys

Hi, Thanks for merging it. There are two things (and they both would take your time I'm afraid) I'd like to discuss about that. First is that I'd like to ask for giving me permission to push into Roassal and Trachel repositories. Second thing, which requires more time and text from my side, is following problem with that "TRMouseMove event had wrong position (visible on exampleMovingEdges)". Thing is, some TREvent events have their position just directly taken from MorphicEvent, but some events have them translated using something like trachelEvent position: trachelCanvas camera fromPixelToSpace: morphicEvent position which is the same translation as TREvent>>#positionFromCamera does. So in some subclasses of TREventthere is this translation already made and saved into "position" from the beginning and therefore calling positionFromCamera on them does not make any sense because it would do the same translation twice (TRKeyDown, TRMouseClick, TRDoubleClick, TRMouseWheel and now also TRMouseMove), but some of them have their original position, so to get their translated position, one HAS to use that positionFromCamera (TRMouseDragEnd, TRMouseDragStart, TRMouseDragging, TRMouseEnter, TRMouseLeave and originally also TRMouseMove). The initial translation happens (or doesn't) in TRMorph methods beginning with "tr...", like "trMouseMove:". trMouseMove originally did not do this translation, but mentioned exampleMovingEdges didn't do this translation either, so it had wrong position. I added this translation into TRMorph, so TRMouseMove>>#position is now already translated, but now, when I look at it again, I am not sure if I should have done that because it could break other users, not sure what should be changed there. Maybe that example, maybe the TRMorph>>#trMouseMove: like I did, or maybe it should be unified and all events should already have this position translated and TREvent>>#positionFromCamera should be removed, or none events should be already translated and users of these events should use this TREvent>>#positionFromCamera in some cases, I don't know. Simplest way would be to just change that example and most uniform way would be probably to have all TREvents their position already translated and TREvent>>#positionFromCamera removed, but it would mean that all users of TRMouseMove, TRMouseDragStart, TRMouseDragEnd, TRMouseDragging, TRMouseEnter and TRMouseLeave would need to adapt. Changing any of this in TR/RT classes would be matter of few seconds-minutes for me, but this is more of a desing choice. I hope the information I wanted to tell could be decrypted out of that text :) Jan abergel wrote -- View this message in context: http://forum.world.st/Roassal2-Events-forwarding-pressed-modifier-keys-tp48… Sent from the Moose mailing list archive at Nabble.com.