[Moose-dev] Re: Mondrian refactorization

Cheers Santiago 2011/5/17 Tudor Girba <tudor(a)tudorgirba.com> Thanks. It works now: http://ci.moosetechnology.org/job/mondrian-latest-dev-on-pharo-1.2/213/ Cheers, Doru On 17 May 2011, at 22:32, Alexandre Bergel wrote: > Can you please lunch the build ? > > Cheers, > Alexandre > > > On 17 May 2011, at 16:03, Tudor Girba wrote: > >> Hi again, >> >> The build based on the 'default' configuration still says that something is missing: >> http://ci.moosetechnology.org/job/mondrian-latest-dev-on-pharo-1.2/ >> >> Cheers, >> Doru >> >> >> On 17 May 2011, at 21:43, Tudor Girba wrote: >> >>> Hi, >>> >>> >>> On 17 May 2011, at 21:37, Alexandre Bergel wrote: >>> >>>> Hi Santiago, >>>> >>>> I updated the configuration. Your new package is now in. >>>> The Jenkins should stop complaining by now :-) >>> >>> I started a build of Mondrian to check. >>> >>>> Each time a node is displayed, a new visitor is created. I do not think this is necessary. >>> >>> This is actually not wanted at all because the renderer might have some state later one. >>> >>> Cheers, >>> Doru >>> >>>> Would you mind to indent the code with a tabulation at each line? For example: >>>> -=-=-=-=-=-=-=-=-= >>>> acceptVisitor: aVisitor >>>> ^aVisitor visitMODashedLineShape: self. >>>> -=-=-=-=-=-=-=-=-= >>>> >>>> -=-=-=-=-=-=-=-=-= >>>> acceptVisitor: aVisitor >>>> ^ aVisitor visitMODashedLineShape: self. >>>> -=-=-=-=-=-=-=-=-= >>>> >>>> Can you remove the 'MO' class prefix from each visit method? (e.g., visitMODashedLineShape: -> visitDashedLineShape:) >>>> I will do some benchmark to see if we are slower, but we should not be actually. >>>> >>>> Cheers, >>>> Alexandre >>>> >>>> >>>>