In any case, I noticed that we are actually using the storage of a group in a wrong way. We should always use the storage which is already a collection instead of directly using the entities of a group.
you lost me on that one: can you explain.
We have
MooseAbstractGroup>>entities ^ self entityStorage elements
EntityStorage that is a subclass of Collection. When we use MooseEntity>>entities, we possibly ask for some conversion (for example, before we converted to Array in RuntimeStorage) and this can be expensive. Instead, internally we should always go through the entityStorage to delegate to the EntityStorage and then rely on that implementation.
Is that clearer?
Can you show an example of what we did wrong and what we should do because I'm not 100% sure I fully understand What is MooseEntity>>entities definition
Doru
Cheers, Doru
-- www.tudorgirba.com
"Problem solving efficiency grows with the abstractness level of problem understanding."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"Be rather willing to give than demanding to get."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev