30 Nov
2010
30 Nov
'10
3:11 a.m.
I noticed that you override two times the changes I
pushed in the PPCompositeTest, and as expected, these changes break most of the external
tests :).
No, I didn't override the changes. I just didn't merge up to now them
because there was too much work involved. To my understanding the
changes are integrated now, no?
The problem was that the added 'result' instance-variable caused
variable shadowing in PPCompositeTest itself and many subclasses.
Additionally it broke some Helvetia tests that I refactored now.
In particular, there are two things that I found
useful:
- the result instance variable holding the side effect of executing #parse:rule:. This is
useful for reusing the grammar tests in the parser tests.
As far as I see this is in there.
- the fail:rule: method for negative tests.
Ok sorry, I think I removed this because there were no senders.
Lukas
--
Lukas Renggli
www.lukas-renggli.ch