[Moose-dev] reviewing moose chef

Hi, I am going over Moose Chef. It's quite cool :). Here are some issues I found: 1. MooseQueryResult currently inherits from Collection. It would be more useful if it would be a MooseGroup because we could directly navigate it in the Moose Finder. I already played with it and it looks like it is not too problematic to get this working. I got 237 of 240 tests green. The 3 left are due to the Composite not working quite properly due to a small mismatch between the semantics of Group and Collection. Is there a reason for why we would want a Collection? If not, I will try to get it fully working and then commit. 2. I like the filters, but they would need to be extended for handling groups of entities. For example, now we can say outOfPackage:, but we should also be allowed to specify outOfPackages:. This should not be hard. 3. Right now, we can work with one entity as a starting point (namespace, package, class or method). We should also be able to have Groups as starting point. For this, I guess we would need some other Traits. 4. There are two references to MooseCompositeQueryResult in TScopingEntityQueries and in TDependencyQueries. This class does not exist. First these methods seem to be overridden in the classes. Second, I guess it should be MooseOutgoingCompositeQueryResult. Am I correct? Cheers, Doru -- www.tudorgirba.com "There are no old things, there are only old ways of looking at them."