Le 03/07/2014 16:12, Tudor Girba a écrit :
Yes, I saw that. My question was if we have an idea of how to set the selection now :)
But that code doesn't change the way the selection works [or that it wasn't working well to start with :(].
The selection has to be recreated since when the displayed list is updated, the selected morphs are destroyed. You do something along the lines of "updateSelectionFromModel", don't you?
Thierry
Doru
On Thu, Jul 3, 2014 at 4:08 PM, Goubier Thierry <thierry.goubier@cea.fr mailto:thierry.goubier@cea.fr> wrote:
Hi Doru, I think there is no relation to 13422. It's easy to check: the 13422 fix is a one liner; just revert MorphTreeMorph>>__updateContentsWithPreviouslyEx__panded: to Alain Plantec's version. Thierry Le 03/07/2014 15:58, Tudor Girba a écrit : Ugh. This is ugly! Any idea of how to fix the problem? Doru On Thu, Jul 3, 2014 at 3:10 PM, Andrei Chis <chisvasileandrei@gmail.com <mailto:chisvasileandrei@gmail.com> <mailto:chisvasileandrei@__gmail.com <mailto:chisvasileandrei@gmail.com>>> wrote: Pharo3.0-30851 breaks the selection in glamour. I guess it's the fix for issue 13422 On Thu, Jul 3, 2014 at 3:01 PM, Andrei Chis <chisvasileandrei@gmail.com <mailto:chisvasileandrei@gmail.com> <mailto:chisvasileandrei@__gmail.com <mailto:chisvasileandrei@gmail.com>>> wrote: Yes, something seems to be broken in Glamour in the latest moose image. This also breaks the debugger. To debug you can switch to the default debugger (SpecDebugger registerToolsOn: Smalltalk tools). On Thu, Jul 3, 2014 at 2:45 PM, Stephan Eggermont <stephan@stack.nl <mailto:stephan@stack.nl> <mailto:stephan@stack.nl <mailto:stephan@stack.nl>>> wrote: Could it be related to the failing test in CI? (Mac Mavericks 10.9.2) GLMUpdateMorphicTest>>__testInvalidateSelection (browser panes first port: #selection) value: 3. entity removeLast. announcer announce: GLMTestAnnouncement. self assert: (browser panes first port: #selection) value isNil. self assert: listMorph model selection isNil When I run the glamour tests from the test runner, there is one TestFailure. If I try to debug it, the debugger doesn't work (shows only one pane) _________________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch> <mailto:Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch>__> https://www.iam.unibe.ch/__mailman/listinfo/moose-dev <https://www.iam.unibe.ch/mailman/listinfo/moose-dev> _________________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch> <mailto:Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch>__> https://www.iam.unibe.ch/__mailman/listinfo/moose-dev <https://www.iam.unibe.ch/mailman/listinfo/moose-dev> -- www.tudorgirba.com <http://www.tudorgirba.com> <http://www.tudorgirba.com> "Every thing has its own flow" _________________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch> https://www.iam.unibe.ch/__mailman/listinfo/moose-dev <https://www.iam.unibe.ch/mailman/listinfo/moose-dev> -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 <tel:%2B33%20%280%29%201%2069%2008%2032%2092> / 83 95 _________________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch> https://www.iam.unibe.ch/__mailman/listinfo/moose-dev <https://www.iam.unibe.ch/mailman/listinfo/moose-dev>
-- www.tudorgirba.com http://www.tudorgirba.com
"Every thing has its own flow"
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev