Hi Lukas,
I noticed that you override two times the changes I pushed in the PPCompositeTest, and as expected, these changes break most of the external tests :).
In particular, there are two things that I found useful:
- the result instance variable holding the side effect of executing #parse:rule:. This is useful for reusing the grammar tests in the parser tests.
- the fail:rule: method for negative tests.
In the last comment, you mentioned that this was due to incompatibilities with Helvetia. Should we create a new class with these utilities?
Cheers,
Doru
--
www.tudorgirba.com
"When people care, great things can happen."
I wanted my PPCompositeParser subclass to save some values as it parses. But
when I added an instance variable, class>>parse: failed with "Error: Unable
to initialize #[instVar name]"
How do I save these intermediate results? Is it not possible to have inst
vars for my own purposes?
Sean
--
View this message in context: http://forum.world.st/PetitParser-instance-variables-tp3062129p3062129.html
Sent from the Moose mailing list archive at Nabble.com.
Hi,
In the latest Glamour, we now make a distinction between actions and selection actions:
- global actions selectors are: #dynamicActions: #act*
- selection action selectors are: #dynamicActionsOnSelection: #selectionAct*
This is interesting because now we can get actions that can work on the overall presentation regardless of the selection. For example, in the MoosePanel we now have a toolbar for each pane (like shown in the attachment) that provides all actions relevant for the current entity.
I am still not satisfied with the way the actions are rendered. At the moment, they take an entire row below the title. I would more like it like in Eclipse, where the actions are rendered next to the tabs. Hopefully this will change in a while when someone will put some effort into the Morphic rendering :)
Cheers,
Doru
--
www.tudorgirba.com
"Every thing has its own flow."
Status: New
Owner: tudor.girba
Labels: Type-Enhancement Priority-Medium Component-Glamour
New issue 486 by tudor.girba: Presentation-wide actions should be displayed
in a toolbar
http://code.google.com/p/moose-technology/issues/detail?id=486
Right now, a browser-wide action is mapped on the toolbar, but for each
individual list we only have contextual actions that are relevant for
selections.
We need to distinguish between the selection and the global actions and
render for each presentation a toolbar.
Updates:
Status: Fixed
Labels: Milestone-4.2
Comment #1 on issue 310 by tudor.girba: Make Glamour loadable without
Mondrian and Magritte
http://code.google.com/p/moose-technology/issues/detail?id=310
The ConfigurationOfGlamour has a Core group that does not load any mondrian
or magritte related packages
According to http://www.lukas-renggli.ch/blog/petitparser-1, "p trim Trims
whitespaces before and after p".
However, the following snippet seems not to trim the whitespace at the end
of the second parser:
stringToParse := 'class=" aClass "'.
parser := ('class="' asParser, $" asParser negate plus trim flatten, '"'
asParser) ==> [ :nodes | nodes second ].
result := parser parse: stringToParse.
self assert: result = 'aClass'. "actually returns ' aClass '"
Should it be stripping the trailing space?
Thanks.
Sean
--
View this message in context: http://forum.world.st/PetitParser-trim-bug-tp3059805p3059805.html
Sent from the Moose mailing list archive at Nabble.com.
Hi,
That's great.
I fixed the sorted issue (the problem was that internally we were calling sort: instead of sorted: and this does not copy the collection).
Cheers,
Doru
On 25 Nov 2010, at 21:18, Alexandre Bergel wrote:
> Hi!
>
> I fixed a number of test cases:
> The tests in MooseFinderTest were yellow because of some icons problems. I fixed this.
>
> For Mondrian:
> All the 310 tests are green in a 12554 (using the 'default' Metacello version).
> They are also green in a 1.1.1 using the Metacello Version '2.1.2'
>
> This left 3 tests.
>
> I looked at:
> testSort
>
> | sorted group collection |
> group := MooseGroup withAll: #(1 3 2).
> collection := group entities.
> sorted := group sorted: [:a :b | a < b].
> self assert: sorted entities ~= collection
>
> It is yellow, I do not understand why. I would expect: sorted entities = collection
>
> I updated testCategoryImporter in: Moose-Tests-SmalltalkImporter-Core-AlexandreBergel.10
> "Update in testCategoryImporter. There was a bug due to the remodularlization."
>
> Cheers,
> Alexandre
>
> On 24 Nov 2010, at 20:21, admin(a)moosetechnology.org wrote:
>
>> See <http://hudson.moosetechnology.org/job/moose-latest-dev/466/>
>>
>>
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>
--
www.tudorgirba.com
"What is more important: To be happy, or to make happy?"
Hi,
I cannot load Moose in Pharo1.2 because of Shout.
It is difficult to debug it, as I cannot open a debugger...
But the problem comes from TextMorphForShoutEditor>>findText which does not exist.
Any idea ?
---
Jannik Laval
Indeed, it looks quite nice. It would be great to have the issues inside the image.
To make it great, we would just need the tiny feature of affecting the issues (replying, creating) :)
Cheers,
Doru
On 23 Nov 2010, at 23:46, Stephan Eggermont wrote:
> Would be to have it in a browser in the image.
>
> An early experiment with the current Moose daily build
> shows it can be done:
>
> http://www.squeaksource.com/GoogleIssuesFeed
>
> Stephan
>
--
www.tudorgirba.com
"What is more important: To be happy, or to make happy?"