hi all, Many test on PetitSmalltalk were failing so i tried to fix them. someone should review the changes, there are many, and it's my first time with petitparser. see attached file. Steps: - evaluate Gofer it smalltalkhubUser: 'Pharo' project: 'MetaRepoForPharo40'; configurationOf: 'PetitParser'; loadBleedingEdge. - and merge attached file Name: PetitSmalltalk-BernardoContreras.84 Author: BernardoContreras Time: 13 March 2015, 9:24:08.132253 pm UUID: fc0534b1-3411-485c-87bc-0afa4eaab84d Ancestors: PetitSmalltalk-TudorGirba.83 PPSmalltalkClassesTests>>#verifyClass:selector: compare the keywordsPositions instead of the selectorParts add PPSmalltalkGrammarTests>>#testPragma17 PPSmalltalkGrammarTests>>#testPragma18 PPSmalltalkParserTests>>#testPragma17 PPSmalltalkParserTests>>#testPragma18 tests pragmas with a keyword message. add PPSmalltalkParser>>#buildSelector: builds a selector from a array of RB tokens for every given test add the keywordsPositions assertion. i think it's needed because the PPSmalltalkClassesTests check the positions. remove RBValueToken>>#inputValue (noone calls it?) HTH, -- Bernardo E.C. Sent from a cheap desktop computer in South America. _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Could you check if this is the correct way to initialize the RBMethodNode?