26 Nov
2005
26 Nov
'05
12:53 a.m.
Hi
Because of some problems, I just wanted to ask if
self error: aMessage
is still the way to signal invalid input in a pier command in the
#doValidate method.
Cheers
Philippe
26 Nov
26 Nov
8:56 a.m.
Philippe Marschall a écrit :
Hi
Because of some problems, I just wanted to ask if
self error: aMessage
is still the way to signal invalid input in a pier command in the
#doValidate method.
It seems Lukas changed this ! Use MAError instead
YourCommand>>validate
MAValidationError on: self
Or one of the subclasses
Bye
12:37 p.m.
YourCommand>>validate
MAValidationError on: self
Or one of the subclasses
Are you really sure about this?
- I can see no #validate in the command hierarchy, #exceute still
sends #doValdiate
- MAValidationError is abstract
- PRRemoveCommand >> #doValidate
super doValidate.
(self structure isRoot)
ifTrue: [ self error: 'Unable to remove root node.' ].
#error: is the one from Object
1:46 p.m.
Sorry for not answering, I am currently in Hamburg and don't have the
laptop not with me. You'll have to wait till monday :-)
Cheers,
Lukas
Zitat von Philippe Marschall <philippe.marschall(a)gmail.com>om>:
--
Lukas Renggli
http://www.lukas-renggli.ch
YourCommand>>validate
MAValidationError on: self
Or one of the subclasses
Are you really sure about this?
- I can see no #validate in the command hierarchy, #exceute still
sends #doValdiate
- MAValidationError is abstract
- PRRemoveCommand >> #doValidate
super doValidate.
(self structure isRoot)
ifTrue: [ self error: 'Unable to remove root node.' ].
#error: is the one from Object
27 Nov
27 Nov
12:24 p.m.
Philippe Marschall a écrit :
The problem if you use #error is that the error message is not user
friendly. Using MAError display just a few lines in top of your form.
Use doValidate instead of validat which doesn't exist :-) sorry
YourCommand>>validate
MAValidationError on: self
Or one of the subclasses
Are you really sure about this?
- I can see no #validate in the command hierarchy, #exceute still
sends #doValdiate
- MAValidationError is abstract
- PRRemoveCommand >> #doValidate
super doValidate.
(self structure isRoot)
ifTrue: [ self error: 'Unable to remove root node.' ].
#error: is the one from Object
28 Nov
28 Nov
1:12 p.m.
- MAValidationError is abstract
Use on of its subclasses.
- PRRemoveCommand >> #doValidate
super doValidate.
(self structure isRoot)
ifTrue: [ self error: 'Unable to remove root node.' ].
Damien is right, I am migrating all the sends to #error: to something
raising a subclass of MAValidationError, however there are still a
few places where that doesn't happen.
Because of some problems, I just wanted to ask if
self error: aMessage
is still the way to signal invalid input in a pier command in the
#doValidate method.
What is your exact problem? A lot of people seem to have troubles
there with lockups etc. I need to have a look at it ...
Lukas
--
Lukas Renggli
http://www.lukas-renggli.ch
4:09 p.m.
What is your exact problem? A lot of people seem to
have troubles
there with lockups etc. I need to have a look at it ...
Doing a self error: in a
#doValidate screws (used to, does no longer
if I use a MAValidationError) up the kernel mutex.
In general if an exception happens during the execution of a command
this screws up the kernel mutex (I was told this is not bug but a
feature that has to do with conituntions, non local returns, the way
exceptions are done in Squeak and Java sucking badly). You could
observe that for example in the demo of the picture gallery
application of Chris.
6963
days inactive
6966
days old
6 comments
4 participants
participants (4)
-
Damien Cassou -
Lukas Renggli -
Lukas Renggli -
Philippe Marschall