30 Oct
2007
30 Oct
'07
12:54 a.m.
I was wondering if it might be worth dispatching the calls
visitBrokenInternalLink: visitEmbeddedInternalLink: etc back to the Link
instance...
So that the types of link can render themselves appropriately.
Keith
30 Oct
30 Oct
1:18 a.m.
Keith Hodges wrote:
I was wondering if it might be worth dispatching the
calls
visitBrokenInternalLink: visitEmbeddedInternalLink: etc back to the Link
instance...
So that the types of link can render themselves appropriately.
Keith
Example:
PRRenderer-visitInternalLink: anObject
anObject isBroken
ifTrue: [ ^ anObject acceptLinkBroken: self ].
(anObject isEmbedded not or: [ self doesRemember: anObject target ])
ifTrue: [ ^ anObject acceptLinkGoto: self ].
self
remember: anObject target
while: [ anObject acceptLinkEmbed: anObject ]
PRInternalLink-acceptLinkBroken: visitor
^ visitor visitInternalLinkBroken: self
PRMyLink-acceptLinkBroken: visitor
^ visitor visitMyLinkBroken: self
Keith
1 Nov
1 Nov
9:21 a.m.
> I was wondering if it might be worth dispatching
the calls
> visitBrokenInternalLink: visitEmbeddedInternalLink: etc back to the
> Link
> instance...
Indeed, that would make the code easier to extend. I keep a note on
that and we can try to refactor that in the near future.
Right now, I have to be a bit careful. I did all kinds of experiments
in the latest commits, that very likely will not all make it into the
next release. I am also waiting for feedback for that matters (see my
next mail).
Cheers,
Lukas
--
Lukas Renggli
http://www.lukas-renggli.ch
6260
days inactive
6263
days old
2 comments
2 participants
participants (2)
-
Keith Hodges -
Lukas Renggli