stylesheet rendering problem on seaside 3.0

List overview All Threads
Download

newer

older

seaside 3.0, blog, book,...

Re: Porting Pier-Setup

Nick Ager

11 Jan 2010 11 Jan '10

1:40 p.m.

On the pier seaside 3.0 code-branch, browsing to: http://localhost:8080/pier/environment/style.css, results in: #[47 42 32 98 108 117 101 112 114 105 110 ... rather than: /* blueprint patches */ h1, h2, h3, h4, h5, h6 { margin: 0; fo.... This issue is caused by a change in how ByteArray is rendered in Seaside 3.0 (the problem was also present prior to merging the latest Pier code): seaside 2.8 Object>>encodeOn: aDocument aDocument print: self displayStriong seaside 3.0 Object>>encodeOn: aDocument aDocument print: self greaseString ByteArray>>greaseString "ByteArrays should not automatically be converted to Strings. You should use a GRCodec for this." ^ self printString changing ByteArray>>greaseString to return self displayString fixes the problem. However I can see there are a number of ways to fix this, and as it's such a low level change I'm sure there was a good reason for displayString to be changed to printString. Thoughts?

Attachments:

attachment.htm (text/html — 1.5 KB)

Show replies by date

Julian Fitzell

11 Jan 11 Jan

7:33 p.m.

Maybe we need to implement #encodeOn: on ByteArray? Lukas? Julian On Mon, Jan 11, 2010 at 4:40 AM, Nick Ager <nick.ager(a)gmail.com> wrote:

...

Lukas Renggli

11:37 p.m.

Has this been fixed, because it works here? Lukas 2010/1/11 Julian Fitzell <jfitzell(a)gmail.com>om>:

...

Maybe we need to implement #encodeOn: on ByteArray? Lukas? Julian On Mon, Jan 11, 2010 at 4:40 AM, Nick Ager <nick.ager(a)gmail.com> wrote:

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch

Nick Ager

12 Jan 12 Jan

1:52 a.m.

Still not working in my image - I thought I'd downloaded the latest seaside3.0 source today, so that's a little odd. ... unless something has changed in Pharo. I'm using Pharo09.12. Does your the implementation of ByteArray>>greaseString match this: ByteArray>>greaseString "ByteArrays should not automatically be converted to Strings. You should use a GRCodec for this." ^ self printString or does your image have an implementation of ByteArray>>encodeOn? 2010/1/11 Lukas Renggli <renggli(a)gmail.com>

...

Has this been fixed, because it works here? Lukas 2010/1/11 Julian Fitzell <jfitzell(a)gmail.com>om>:

Maybe we need to implement #encodeOn: on ByteArray? Lukas? Julian On Mon, Jan 11, 2010 at 4:40 AM, Nick Ager <nick.ager(a)gmail.com> wrote: > On the pier seaside 3.0 code-branch, browsing > to: http://localhost:8080/pier/environment/style.css, results in: > #[47 42 32 98 108 117 101 112 114 105 110 ... > rather than: > /* blueprint patches */ > h1, h2, h3, h4, h5, h6 { margin: 0; fo.... > This issue is caused by a change in how ByteArray is rendered in Seaside

3.0

> (the problem was also present prior to merging the latest Pier code): > seaside 2.8 > Object>>encodeOn: aDocument > aDocument print: self displayStriong > seaside 3.0 > Object>>encodeOn: aDocument > aDocument print: self greaseString > ByteArray>>greaseString > "ByteArrays should not automatically be converted to Strings. You should

use

> a GRCodec for this." > ^ self printString > changing ByteArray>>greaseString to return self displayString fixes the > problem. However I can see there are a number of ways to fix this, and

it's such a low level change I'm sure there was a good reason for displayString to be changed to printString. Thoughts? _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Lukas Renggli

8:35 a.m.

...

Does your the implementation of ByteArray>>greaseString match this: ByteArray>>greaseString "ByteArrays should not automatically be converted to Strings. You should use a GRCodec for this." ^ self printString

Yes.

...

or does your image have an implementation of ByteArray>>encodeOn?

No. Maybe you should clear your browser caches? Lukas

...

2010/1/11 Lukas Renggli <renggli(a)gmail.com>

Has this been fixed, because it works here? Lukas 2010/1/11 Julian Fitzell <jfitzell(a)gmail.com>om>:

Maybe we need to implement #encodeOn: on ByteArray? Lukas? Julian On Mon, Jan 11, 2010 at 4:40 AM, Nick Ager <nick.ager(a)gmail.com> wrote:

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch

Nick Ager

11:24 a.m.

Hi Lukas, Don't think the browse cache is the problem. What do you get with: #[100 101 98 117 103 103 105 110 103] greaseString on my image the result: '#[100 101 98 117 103 103 105 110 103]' 2010/1/12 Lukas Renggli <renggli(a)gmail.com>

...

Does your the implementation of ByteArray>>greaseString match this: ByteArray>>greaseString "ByteArrays should not automatically be converted to Strings. You should

use

a GRCodec for this." ^ self printString

Yes.

or does your image have an implementation of ByteArray>>encodeOn?

No. Maybe you should clear your browser caches? Lukas

wrote:

> >> On the pier seaside 3.0 code-branch, browsing > >> to: http://localhost:8080/pier/environment/style.css, results in: > >> #[47 42 32 98 108 117 101 112 114 105 110 ... > >> rather than: > >> /* blueprint patches */ > >> h1, h2, h3, h4, h5, h6 { margin: 0; fo.... > >> This issue is caused by a change in how ByteArray is rendered in > >> Seaside 3.0 > >> (the problem was also present prior to merging the latest Pier code): > >> seaside 2.8 > >> Object>>encodeOn: aDocument > >> aDocument print: self displayStriong > >> seaside 3.0 > >> Object>>encodeOn: aDocument > >> aDocument print: self greaseString > >> ByteArray>>greaseString > >> "ByteArrays should not automatically be converted to Strings. You > >> should use > >> a GRCodec for this." > >> ^ self printString > >> changing ByteArray>>greaseString to return self displayString fixes

the

> >> problem. However I can see there are a number of ways to fix this,

and

> as > it's such a low level change I'm sure there was a good reason for > displayString to be changed to printString. Thoughts? > > _______________________________________________ > Magritte, Pier and Related Tools ... > https://www.iam.unibe.ch/mailman/listinfo/smallwiki > _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Lukas Renggli

11:59 a.m.

#[100 101 98 117 103 103 105 110 103], but this method is never called when I browse Pier. Lukas 2010/1/12 Nick Ager <nick.ager(a)gmail.com>om>:

...

Yes.

or does your image have an implementation of ByteArray>>encodeOn?

No. Maybe you should clear your browser caches? Lukas

2010/1/11 Lukas Renggli <renggli(a)gmail.com>

Has this been fixed, because it works here? Lukas 2010/1/11 Julian Fitzell <jfitzell(a)gmail.com>om>: > Maybe we need to implement #encodeOn: on ByteArray? Lukas? > > Julian > > On Mon, Jan 11, 2010 at 4:40 AM, Nick Ager <nick.ager(a)gmail.com> > wrote: >> On the pier seaside 3.0 code-branch, browsing >> to: http://localhost:8080/pier/environment/style.css, results in: >> #[47 42 32 98 108 117 101 112 114 105 110 ... >> rather than: >> /* blueprint patches */ >> h1, h2, h3, h4, h5, h6 { margin: 0; fo.... >> This issue is caused by a change in how ByteArray is rendered in >> Seaside 3.0 >> (the problem was also present prior to merging the latest Pier >> code): >> seaside 2.8 >> Object>>encodeOn: aDocument >> aDocument print: self displayStriong >> seaside 3.0 >> Object>>encodeOn: aDocument >> aDocument print: self greaseString >> ByteArray>>greaseString >> "ByteArrays should not automatically be converted to Strings. You >> should use >> a GRCodec for this." >> ^ self printString >> changing ByteArray>>greaseString to return self displayString fixes >> the >> problem. However I can see there are a number of ways to fix this, >> and >> as >> it's such a low level change I'm sure there was a good reason for >> displayString to be changed to printString. Thoughts? >> >> _______________________________________________ >> Magritte, Pier and Related Tools ... >> https://www.iam.unibe.ch/mailman/listinfo/smallwiki >> > > _______________________________________________ > Magritte, Pier and Related Tools ... > https://www.iam.unibe.ch/mailman/listinfo/smallwiki > -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch

Julian Fitzell

10:50 p.m.

I'm seeing the same as Nick, fwiw. Same if I try to edit the stylesheet. Julian On Tue, Jan 12, 2010 at 2:59 AM, Lukas Renggli <renggli(a)gmail.com> wrote:

...

#[100 101 98 117 103 103 105 110 103], but this method is never called when I browse Pier. Lukas 2010/1/12 Nick Ager <nick.ager(a)gmail.com>om>:

Yes.

or does your image have an implementation of ByteArray>>encodeOn?

No. Maybe you should clear your browser caches? Lukas

2010/1/11 Lukas Renggli <renggli(a)gmail.com> > > Has this been fixed, because it works here? > > Lukas > > 2010/1/11 Julian Fitzell <jfitzell(a)gmail.com>om>: > > Maybe we need to implement #encodeOn: on ByteArray? Lukas? > > > > Julian > > > > On Mon, Jan 11, 2010 at 4:40 AM, Nick Ager <nick.ager(a)gmail.com> > > wrote: > >> On the pier seaside 3.0 code-branch, browsing > >> to: http://localhost:8080/pier/environment/style.css, results in: > >> #[47 42 32 98 108 117 101 112 114 105 110 ... > >> rather than: > >> /* blueprint patches */ > >> h1, h2, h3, h4, h5, h6 { margin: 0; fo.... > >> This issue is caused by a change in how ByteArray is rendered in > >> Seaside 3.0 > >> (the problem was also present prior to merging the latest Pier > >> code): > >> seaside 2.8 > >> Object>>encodeOn: aDocument > >> aDocument print: self displayStriong > >> seaside 3.0 > >> Object>>encodeOn: aDocument > >> aDocument print: self greaseString > >> ByteArray>>greaseString > >> "ByteArrays should not automatically be converted to Strings. You > >> should use > >> a GRCodec for this." > >> ^ self printString > >> changing ByteArray>>greaseString to return self displayString fixes > >> the > >> problem. However I can see there are a number of ways to fix this, > >> and > >> as > >> it's such a low level change I'm sure there was a good reason for > >> displayString to be changed to printString. Thoughts? > >> > >> _______________________________________________ > >> Magritte, Pier and Related Tools ... > >> https://www.iam.unibe.ch/mailman/listinfo/smallwiki > >> > > > > _______________________________________________ > > Magritte, Pier and Related Tools ... > > https://www.iam.unibe.ch/mailman/listinfo/smallwiki > > > > > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Magritte, Pier and Related Tools ... > https://www.iam.unibe.ch/mailman/listinfo/smallwiki _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Nick Ager

11:59 p.m.

I've tried to encapsulate the problem in a test: | stylesheetFile stylesheetContents rendererResult | stylesheetContents := '/* a style sheet */'. stylesheetFile := (PRFile named: 'defaultCss') filename: 'style.css'; mimetype: 'text/css'; contents: stylesheetContents. rendererResult := WARenderCanvas builder render: [ :html | html render: stylesheetFile file contents]. self assert: rendererResult = stylesheetContents In my image the assertion fails. If I change ByteArray>>greaseString to return self displayString the assertion succeeds. Does that help? 2010/1/12 Julian Fitzell <jfitzell(a)gmail.com>

...

I'm seeing the same as Nick, fwiw. Same if I try to edit the stylesheet. Julian On Tue, Jan 12, 2010 at 2:59 AM, Lukas Renggli <renggli(a)gmail.com> wrote:

#[100 101 98 117 103 103 105 110 103], but this method is never called when I browse Pier. Lukas 2010/1/12 Nick Ager <nick.ager(a)gmail.com>om>: > Hi Lukas, > Don't think the browse cache is the problem. What do you get with: > #[100 101 98 117 103 103 105 110 103] greaseString > on my image the result: > '#[100 101 98 117 103 103 105 110 103]' > > 2010/1/12 Lukas Renggli <renggli(a)gmail.com> >> >> > Does your the implementation of >> > ByteArray>>greaseString match this: >> > ByteArray>>greaseString >> > "ByteArrays should not automatically be converted to Strings. You

should

>> > use >> > a GRCodec for this." >> > ^ self printString >> >> Yes. >> >> > or does your image have an implementation of ByteArray>>encodeOn? >> >> No. >> >> Maybe you should clear your browser caches? >> >> Lukas >> >> > 2010/1/11 Lukas Renggli <renggli(a)gmail.com> >> >> >> >> Has this been fixed, because it works here? >> >> >> >> Lukas >> >> >> >> 2010/1/11 Julian Fitzell <jfitzell(a)gmail.com>om>: >> >> > Maybe we need to implement #encodeOn: on ByteArray? Lukas? >> >> > >> >> > Julian >> >> > >> >> > On Mon, Jan 11, 2010 at 4:40 AM, Nick Ager <nick.ager(a)gmail.com> >> >> > wrote: >> >> >> On the pier seaside 3.0 code-branch, browsing >> >> >> to: http://localhost:8080/pier/environment/style.css, results

in:

>> >> >> #[47 42 32 98 108 117 101 112 114 105 110 ... >> >> >> rather than: >> >> >> /* blueprint patches */ >> >> >> h1, h2, h3, h4, h5, h6 { margin: 0; fo.... >> >> >> This issue is caused by a change in how ByteArray is rendered in >> >> >> Seaside 3.0 >> >> >> (the problem was also present prior to merging the latest Pier >> >> >> code): >> >> >> seaside 2.8 >> >> >> Object>>encodeOn: aDocument >> >> >> aDocument print: self displayStriong >> >> >> seaside 3.0 >> >> >> Object>>encodeOn: aDocument >> >> >> aDocument print: self greaseString >> >> >> ByteArray>>greaseString >> >> >> "ByteArrays should not automatically be converted to Strings. You >> >> >> should use >> >> >> a GRCodec for this." >> >> >> ^ self printString >> >> >> changing ByteArray>>greaseString to return self displayString

fixes

>> >> >> the >> >> >> problem. However I can see there are a number of ways to fix

this,

>> >> and >> >> as >> >> it's such a low level change I'm sure there was a good reason for >> >> displayString to be changed to printString. Thoughts? >> >> >> >> _______________________________________________ >> >> Magritte, Pier and Related Tools ... >> >> https://www.iam.unibe.ch/mailman/listinfo/smallwiki >> >> >> > >> > _______________________________________________ >> > Magritte, Pier and Related Tools ... >> > https://www.iam.unibe.ch/mailman/listinfo/smallwiki >> > >> >> >> >> -- >> Lukas Renggli >> http://www.lukas-renggli.ch >> >> _______________________________________________ >> Magritte, Pier and Related Tools ... >> https://www.iam.unibe.ch/mailman/listinfo/smallwiki > > > _______________________________________________ > Magritte, Pier and Related Tools ... > https://www.iam.unibe.ch/mailman/listinfo/smallwiki > -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

-- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

_______________________________________________ Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Nick Ager

13 Jan 13 Jan

12:05 a.m.

I wonder if we've made it clear that stylesheet renders fine as a style sheet, it's only when you use Pier to view the stylesheet 'file' is the result is something like '[47 42 32 98 108 117 101 112 114 105 110 ..' Anyway hopefully the test above encapsulates the problem.

5225

days inactive

5226

days old

smallwiki@list.inf.unibe.ch

Manage subscription

9 comments

3 participants

tags (0)

participants (3)

Julian Fitzell
Lukas Renggli
Nick Ager