23 Mar
2009
23 Mar
'09
12:37 p.m.
Hello Lukas,
I found that MAInternalEditorComponent is doing this
renderEditorOn: html
super renderEditorOn: html.
html hiddenInput callback: [ self component commit ]
Am I correct in thinking that this means that the commit to the model is
occurring every time the form submits? I thought that the commit should
be to the memento, when validation etc has passed.
Keith
23 Mar
23 Mar
7:02 p.m.
I found that MAInternalEditorComponent is doing this
renderEditorOn: html
super renderEditorOn: html.
html hiddenInput callback: [ self component commit ]
Am I correct in thinking that this means that the commit to the model is
occurring every time the form submits? I thought that the commit should
be to the memento, when validation etc has passed.
Yeah, looks suspicious. I committed a fix for this particular issue in
Magritte-Seaside-lr.285.
Note, that I rarely use the to-many relationship descriptions, so that
there might be more bugs lingering around ...
Lukas
--
Lukas Renggli
http://www.lukas-renggli.ch
11:37 p.m.
Lukas Renggli wrote:
One or two ;-)
I adopted your fix to see what difference it makes. Looks good so far.
I have posted fixes to two further issues.
Controls one level down i.e.
Container(1)>>Control=Container(2)>>Control
dont have access to the errors list of container (1) in order to display
class: 'error', in #forClass:
my solution uses a Notification.
Validation in the component heirarchy raises non-resumable errors,
whereas the model validation raises resumable errors resulting in wierd
behaviour.
Again I uploaded a fix for this
Keith
I found that
MAInternalEditorComponent is doing this
renderEditorOn: html
super renderEditorOn: html.
html hiddenInput callback: [ self component commit ]
Am I correct in thinking that this means that the commit to the model is
occurring every time the form submits? I thought that the commit should
be to the memento, when validation etc has passed.
Yeah, looks suspicious. I committed a fix for this particular issue in
Magritte-Seaside-lr.285.
Note, that I rarely use the to-many relationship descriptions, so that
there might be more bugs lingering around ...
24 Mar
24 Mar
8:34 a.m.
I published a different fix that does not use resumable exceptions,
but instead asks the parent if there are any errors to report
Magritte-Seaside-lr.286.
Lukas
On Mon, Mar 23, 2009 at 11:37 PM, Keith Hodges <keith_hodges(a)yahoo.co.uk> wrote:
Lukas Renggli wrote:
One or two ;-)
I adopted your fix to see what difference it makes. Looks good so far.
I have posted fixes to two further issues.
Controls one level down i.e.
Container(1)>>Control=Container(2)>>Control
dont have access to the errors list of container (1) in order to display
class: 'error', in #forClass:
my solution uses a Notification.
Validation in the component heirarchy raises non-resumable errors,
whereas the model validation raises resumable errors resulting in wierd
behaviour.
Again I uploaded a fix for this
Keith
_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
--
Lukas Renggli
http://www.lukas-renggli.ch
I found
that MAInternalEditorComponent is doing this
renderEditorOn: html
super renderEditorOn: html.
html hiddenInput callback: [ self component commit ]
Am I correct in thinking that this means that the commit to the model is
occurring every time the form submits? I thought that the commit should
be to the memento, when validation etc has passed.
Yeah, looks suspicious. I committed a fix for this particular issue in
Magritte-Seaside-lr.285.
Note, that I rarely use the to-many relationship descriptions, so that
there might be more bugs lingering around ...
1:13 p.m.
New subject: LightBox links broken in PRMenuWidget
Lukas Renggli wrote:
I published a different fix that does not use
resumable exceptions,
but instead asks the parent if there are any errors to report
Magritte-Seaside-lr.286.
Lukas
Cool thanks,
I thought that children asking parents was considered bad form.
btw: The MenuWidget is clueless about lightbox links.
Keith
1:48 p.m.
New subject: LightBox links broken in PRMenuWidget
Keith Hodges wrote:
Lukas Renggli wrote:
I have submitted a naive fix for the lightbox issue.
How does one normally get back from the lightbox? (As in back to the
structure that you came from).
You still need to address the issue about validation errors being raised
non-resumable. They need to be raised, or modified to be resumable.
Keith
I published a different fix that does not use
resumable exceptions,
but instead asks the parent if there are any errors to report
Magritte-Seaside-lr.286.
Lukas
Cool thanks,
I thought that children asking parents was considered bad form.
btw: The MenuWidget is clueless about lightbox links.
Keith
2:50 p.m.
New subject: LightBox links broken in PRMenuWidget
I have submitted a naive fix for the lightbox issue.
That code should be part of the package Pier-Lightbox, not Pier-Seaside.
How does one normally get back from the lightbox? (As
in back to the
structure that you came from).
Pressing the close button of the lightbox?
You still need to address the issue about validation
errors being raised
non-resumable. They need to be raised, or modified to be resumable.
We need to get rid of those ugly exceptions all-together.
Lukas
--
Lukas Renggli
http://www.lukas-renggli.ch
3:19 p.m.
New subject: LightBox links broken in PRMenuWidget
Lukas Renggli wrote:
I couldnt see it. I also cant find any styling in my pier installation
that would make it visible.
Keith
I have
submitted a naive fix for the lightbox issue.
That code should be part of the package Pier-Lightbox, not Pier-Seaside.
How does one normally get back from the lightbox?
(As in back to the
structure that you came from).
Pressing the close button of the lightbox?
3:21 p.m.
New subject: LightBox links broken in PRMenuWidget
I couldnt see it. I also cant find any styling in my
pier installation
that would make it visible.
See here for example: <http://www.seaside.st/about/screenshots>
Lukas
--
Lukas Renggli
http://www.lukas-renggli.ch
4:03 p.m.
New subject: LightBox links broken in PRMenuWidget
You definitely have to add styling for the lightbox id. Note that it is an
ID not a class
#lightbox .head, .body {
background-color: white;
border: solid 2px;
border-color: green; }
On Tue, Mar 24, 2009 at 10:21 AM, Lukas Renggli <renggli(a)gmail.com> wrote:
I couldnt see
it. I also cant find any styling in my pier installation
that would make it visible.
See here for example: <http://www.seaside.st/about/screenshots>
Lukas
--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
2:42 p.m.
New subject: LightBox links broken in PRMenuWidget
I thought that children asking parents was considered
bad form.
Yes, because it makes reuse impossible.
However in the case of Magritte this is for a composite of private
component classes that make up a single form. The parent information
is only maintained within this group and was introduced to be able to
replace the outermost editor component with a new form.
Lukas
--
Lukas Renggli
http://www.lukas-renggli.ch
5751
days inactive
5752
days old
10 comments
3 participants
participants (3)
-
John McKeon -
Keith Hodges -
Lukas Renggli