27 Jan
2010
27 Jan
'10
4:10 p.m.
Hi
Yesterday I rebuilt my image using the latest
Metacello ConfigurationOfSeaside30 (loadLatestVersion) and the latest code
in Pier2 and Magritte2 repositories. I've noticed a new problem when I
attempt to add a component using the Pier web ui which results in a form
validation error: 'Component Class: Invalid input given'
To reproduce:
* download latest build from:
http://hudson.lukas-renggli.ch/job/Seaside%203.0/
<http://hudson.lukas-renggli.ch/job/Seaside%203.0/>* open and start web
server
* open a workspace and execute:
PRPierFrame registerAsApplication: 'pier' kernel: (PRKernel named:
'defaultKernel').
* browse to http://localhost:8080/pier and select the edit link
* type: '+acomponent+' into the text in the box and press 'save'
* click on the 'acomponent' link and in the type select list choose
'Component' and press 'Add'
* select any class from the 'Component Class' select list and press
'save'
* note the form validation error: "Component Class: Invalid input given"
Investigation:
* MAKindError is being generated as the component selected is always
WAComponent regardless of the user selection.
* WAComponent is the default value ; the selected value is not being set as
the callback in MASelectListComponent>>renderOption:on: is never called.
This appears to be a Seaside bug; it appears that the callbacks for a
grouped select list are not called on form submission.
Further investigation:
* using the latest build browse to http://localhost:8080/magritte/editor
* select a type other than 'Boolean' from the grouped select box eg choose
'File' and press Add
* notice that whatever type you choose 'Boolean' is always selected.
* place a 'self halt' in the callback in
MASelectListComponent>>renderOption:on:
and notice that it is never called.
I noticed that there have been bug fixes on the select tag:
http://lists.squeakfoundation.org/pipermail/seaside/2010-January/022358.html
I made sure that the build I was using had the latest Seaside-Canvas
(Seaside-Canvas-lr.88.mcz). My previous image with working grouped selection
list was based on Seaside-Canvas-pmm.74.mcz
Hope I'm not reporting something that has already been fixed or noticed
elsewhere
Nick
28 Jan
28 Jan
12:33 p.m.
New subject: new bug: unable to use Pier UI to add components -> bug in grouped select
That's a Seaside bug. I thought I fixed the refactoring of the select
and option boxes to be fully backward compatible. Are you sure you
have absolutely the latest Seaside code?
Lukas
On 27 January 2010 16:10, Nick Ager <nick.ager(a)gmail.com> wrote:
Hi
Yesterday I rebuilt my image using the latest
Metacello ConfigurationOfSeaside30 (loadLatestVersion) and the latest code
in Pier2 and Magritte2 repositories. I've noticed a new problem when I
attempt to add a component using the Pier web ui which results in a form
validation error: 'Component Class: Invalid input given'
To reproduce:
* download latest build
from: http://hudson.lukas-renggli.ch/job/Seaside%203.0/
* open and start web server
* open a workspace and execute:
PRPierFrame registerAsApplication: 'pier' kernel: (PRKernel named:
'defaultKernel').
* browse to http://localhost:8080/pier and select the edit link
* type: '+acomponent+' into the text in the box and press 'save'
* click on the 'acomponent' link and in the type select list choose
'Component' and press 'Add'
* select any class from the 'Component Class' select list and press
'save'
* note the form validation error: "Component Class: Invalid input given"
Investigation:
* MAKindError is being generated as the component selected is always
WAComponent regardless of the user selection.
* WAComponent is the default value ; the selected value is not being set as
the callback in MASelectListComponent>>renderOption:on: is never called.
This appears to be a Seaside bug; it appears that the callbacks for a
grouped select list are not called on form submission.
Further investigation:
* using the latest build browse to http://localhost:8080/magritte/editor
* select a type other than 'Boolean' from the grouped select box eg choose
'File' and press Add
* notice that whatever type you choose 'Boolean' is always selected.
* place a 'self halt' in the callback
in MASelectListComponent>>renderOption:on: and notice that it is never
called.
I noticed that there have been bug fixes on the select
tag: http://lists.squeakfoundation.org/pipermail/seaside/2010-January/022358.html
I made sure that the build I was using had the latest Seaside-Canvas
(Seaside-Canvas-lr.88.mcz). My previous image with working grouped selection
list was based on Seaside-Canvas-pmm.74.mcz
Hope I'm not reporting something that has already been fixed or noticed
elsewhere
Nick
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
--
Lukas Renggli
http://www.lukas-renggli.ch
2:30 p.m.
New subject: new bug: unable to use Pier UI to add components -> bug in grouped select
Hi Lukas,
On 28 January 2010 11:33, Lukas Renggli <renggli(a)gmail.com> wrote:
That's a Seaside bug. I thought I fixed the
refactoring of the select
and option boxes to be fully backward compatible. Are you sure you
have absolutely the latest Seaside code?
I just checked again with the latest Seaside code and saw the problem. Note
it's only a problem with grouped selects and the only place I've seen them
used within the framework is within Pier and Magritte.
Hope this helps
Nick
3:47 p.m.
New subject: new bug: unable to use Pier UI to add components -> bug in grouped select
On 28 January 2010 14:30, Nick Ager <nick.ager(a)gmail.com> wrote:
Hi Lukas,
On 28 January 2010 11:33, Lukas Renggli <renggli(a)gmail.com> wrote:
Unfortunately all Seaside code got rewritten (and thus option groups
and select lists) and now all old code is broken. I prefer to fix it
in Seaside though. I'll have a look.
Lukas
That's a Seaside bug. I thought I fixed the refactoring of the select
and option boxes to be fully backward compatible. Are you sure you
have absolutely the latest Seaside code?
I just checked again with the latest Seaside code and saw the problem. Note
it's only a problem with grouped selects and the only place I've seen them
used within the framework is within Pier and Magritte. Hope this helps
Nick
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
--
Lukas Renggli
http://www.lukas-renggli.ch
29 Jan
29 Jan
8:56 a.m.
New subject: new bug: unable to use Pier UI to add components -> bug in grouped select
Ok, this was mostly a Magritte problem; and a little bit a Seaside problem.
For the Magritte part I've applied an ugly fix and created Issue 3
(groupBy is totally buggy):
http://code.google.com/p/magritte-metamodel/issues/detail?id=3
For the Seaside part I think in this rare case it just requires some
change in the code.
Lukas
On 28 January 2010 15:47, Lukas Renggli <renggli(a)gmail.com> wrote:
On 28 January 2010 14:30, Nick Ager
<nick.ager(a)gmail.com> wrote:
--
Lukas Renggli
http://www.lukas-renggli.ch
Hi Lukas,
On 28 January 2010 11:33, Lukas Renggli <renggli(a)gmail.com> wrote:
Unfortunately all Seaside code got rewritten (and thus option groups
and select lists) and now all old code is broken. I prefer to fix it
in Seaside though. I'll have a look.
Lukas
That's a Seaside bug. I thought I fixed the refactoring of the select
and option boxes to be fully backward compatible. Are you sure you
have absolutely the latest Seaside code?
I just checked again with the latest Seaside code and saw the problem. Note
it's only a problem with grouped selects and the only place I've seen them
used within the framework is within Pier and Magritte. Hope this helps
Nick
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
--
Lukas Renggli
http://www.lukas-renggli.ch
8:56 a.m.
New subject: new bug: unable to use Pier UI to add components -> bug in grouped select
Aha, and this is the fix:
Name: Magritte-Seaside-lr.329
Author: lr
Time: 29 January 2010, 8:55 am
UUID: c7872691-db24-4a19-8387-480a5d467d0f
Ancestors: Magritte-Seaside-NickAger.328
- fixed some bugs that were introduced with some recent seaside verisons
On 29 January 2010 08:56, Lukas Renggli <renggli(a)gmail.com> wrote:
Ok, this was mostly a Magritte problem; and a little
bit a Seaside problem.
For the Magritte part I've applied an ugly fix and created Issue 3
(groupBy is totally buggy):
http://code.google.com/p/magritte-metamodel/issues/detail?id=3
For the Seaside part I think in this rare case it just requires some
change in the code.
Lukas
On 28 January 2010 15:47, Lukas Renggli <renggli(a)gmail.com> wrote:
--
Lukas Renggli
http://www.lukas-renggli.ch
On 28 January 2010 14:30, Nick Ager
<nick.ager(a)gmail.com> wrote:
--
Lukas Renggli
http://www.lukas-renggli.ch
Hi Lukas,
On 28 January 2010 11:33, Lukas Renggli <renggli(a)gmail.com> wrote:
Unfortunately all Seaside code got rewritten (and thus option groups
and select lists) and now all old code is broken. I prefer to fix it
in Seaside though. I'll have a look.
Lukas
That's a Seaside bug. I thought I fixed the refactoring of the select
and option boxes to be fully backward compatible. Are you sure you
have absolutely the latest Seaside code?
I just checked again with the latest Seaside code and saw the problem. Note
it's only a problem with grouped selects and the only place I've seen them
used within the framework is within Pier and Magritte. Hope this helps
Nick
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
--
Lukas Renggli
http://www.lukas-renggli.ch
11:49 a.m.
New subject: new bug: unable to use Pier UI to add components -> bug in grouped select
On 29 January 2010 07:56, Lukas Renggli <renggli(a)gmail.com> wrote:
Aha, and this is the fix:
Name: Magritte-Seaside-lr.329
Author: lr
Time: 29 January 2010, 8:55 am
UUID: c7872691-db24-4a19-8387-480a5d467d0f
Ancestors: Magritte-Seaside-NickAger.328
- fixed some bugs that were introduced with some recent seaside verisons
Thanks problem solved - fantastic
5440
days inactive
5442
days old
6 comments
2 participants
participants (2)
-
Lukas Renggli -
Nick Ager