Hi,
I touched some packages I want you to take notice of. I found the code in AudioScrobbler
useful that does xml binding stuff with magritte. I decided to rip it out into a new
package to enhance it for write support.
Basically I just divided ASObject from AudioScrobbler in two classes:
- MXObject carries all the xml binding stuff
- ASObject deal with network stuff (curl etc.)
All *Reader classes in AudioScrobbler moved into the new package as well as the extensions
to MADescription etc. The prefix changed from AS to MX.
I wanted to leave a clean state behind. There are dependencies between AudioScrobbler,
Topfeeder and NetworkAddress. All used old magritte semantics so I had to change all of
them.
So I touched 4 packages:
- NetworkAddress (magritteaddons repo)
- Magritte-XMLBinding (created in magritteaddons repo)
- AudioScrobbler (audioscrobbler repo)
- TopFeeder (topfeeder repo)
All tests were green afterwards while top feeder takes ages. There is a starting
implementation for write support that is just at its beginning. I checked the package in
to resolve all inter-package dependencies. As far as I can tell there hasn't been a
side effect so far regarding the refactoring.
Norbert
Show replies by date