26 Nov
2003
26 Nov
'03
2:07 a.m.
If you load 0.9.23 from the public repository into a new image, the tests
don't run. The various structure #initialize class methods have been
removed, so the class instance variables aren't initialized. Instead of
adding the methods back, could the code be changed so that these variables
are lazily initialized?
Also, the VisitorRendererWiki>>emitCrWithoutDuplicates assumes that #cr
method on stream emits only a Character cr. However, the ANSI standard says
that #cr emits "a sequence of character objects that constitute the
implementation-defined end-of-line sequence" so you can't assume that
Character cr will be put on the stream. Instead of getting the contents, I
would suggest adding an instance variable that says whether the last thing
put on the stream was a #cr from #emitCr.
John Brant
26 Nov
26 Nov
11:18 a.m.
If you load 0.9.23 from the public repository into a
new image, the
tests
don't run. The various structure #initialize class methods have been
removed, so the class instance variables aren't initialized. Instead of
adding the methods back, could the code be changed so that these
variables
are lazily initialized?
I am very sorry, this is my fault. The Squeak porters requested to have
those class variables to be lazily initialized, but I forgot to use the
accessors at one place. This should be fixed in 0.9.24.
Btw, does anybody care if I take the SIXX storage out of the
core-package? I would like to remove the dependency of SmallWiki to
SIXX. I don't think that anybody is actually using it. I put it into
the example collection, from where you might still load if you need.
Also, the
VisitorRendererWiki>>emitCrWithoutDuplicates assumes that #cr
method on stream emits only a Character cr. However, the ANSI standard
says
that #cr emits "a sequence of character objects that constitute the
implementation-defined end-of-line sequence" so you can't assume that
Character cr will be put on the stream. Instead of getting the
contents, I
would suggest adding an instance variable that says whether the last
thing
put on the stream was a #cr from #emitCr.
I changed the implementation of this part as suggested and I think it
also looks much nicer now.
Btw, talking about visitors:
- I basically use the same naming conventions as the refactoring
browser for the messages #accept:, #acceptFolder:, #visit:, etc.
Several people were complaining that this does not match the
suggestions of the book Smalltalk design-pattern companion and was
confusing them. I don't really care what approach to take, but would be
interested in your opinion?
- Another thing about the visitors are their class-names. If I remember
correctly you told me in one of your reviews that you dislike those
names. So far I did not change anything, but when doing a visitor
refactoring I would like to do everything at once. What class-naming
would you prefer exactly?
Regards,
Lukas
--
Lukas Renggli
http://renggli.freezope.org
3:33 p.m.
From: owner-smallwiki(a)iam.unibe.ch
[mailto:owner-smallwiki@iam.unibe.ch]
On Behalf Of Lukas Renggli
Btw, talking about visitors:
- I basically use the same naming conventions as the refactoring
browser for the messages #accept:, #acceptFolder:, #visit:, etc.
Several people were complaining that this does not match the
suggestions of the book Smalltalk design-pattern companion and was
confusing them. I don't really care what approach to take, but would be
interested in your opinion?
This doesn't bother me -- I didn't learn visitor from the DP book. However,
if it makes it clearer for others, then you should do it.
- Another thing about the visitors are their
class-names. If I remember
correctly you told me in one of your reviews that you dislike those
names. So far I did not change anything, but when doing a visitor
refactoring I would like to do everything at once. What class-naming
would you prefer exactly?
Essentially, the names are backwards to me: instead of VisitorPluggable, I
prefer PluggableVisitor; instead of VisitorRendererHtml, I prefer
HtmlRenderingVisitor; etc. I believe this was one of Kent's patterns.
Anyway, there are some other classes besides the visitors with the reversed
class names (e.g., LinkExternal).
John Brant
27 Nov
27 Nov
8:18 a.m.
This doesn't bother me -- I didn't learn
visitor from the DP book.
However,
if it makes it clearer for others, then you should do it.
Yes especially because lot of people will learn Smalltalk based on
SmallWiki :)
Roel here as 16 projects based on SmallWiki. So your code will be the
first one
for a lot of newbies :)
- Another
thing about the visitors are their class-names. If I
remember
correctly you told me in one of your reviews that you dislike those
names. So far I did not change anything, but when doing a visitor
refactoring I would like to do everything at once. What class-naming
would you prefer exactly?
Essentially, the names are backwards to me: instead of
VisitorPluggable, I
prefer PluggableVisitor; instead of VisitorRendererHtml, I prefer
HtmlRenderingVisitor; etc. I believe this was one of Kent's patterns.
Anyway, there are some other classes besides the visitors with the
reversed
class names (e.g., LinkExternal).
John Brant
11:30 p.m.
New subject: Naming the classes of smallwiki
John Brant wrote:
Essentially, the names are backwards to me: instead of VisitorPluggable, I
prefer PluggableVisitor; instead of VisitorRendererHtml, I prefer
HtmlRenderingVisitor; etc. I believe this was one of Kent's patterns.
Anyway, there are some other classes besides the visitors with the reversed
class names (e.g., LinkExternal).
Yes the names are backwards but this is probably not justified.
The more general thing comes first and then the specific thing.
(noun then adjective).
If I search for 'Visitor' I get the list of visitors to choose from.
So I do not think it is worth the effort of changing the names
to conform to English word order.
Hannes Hirzel
28 Nov
28 Nov
7:52 a.m.
New subject: Naming the classes of smallwiki (correct version)
CORRECT VERSION
Hannes Hirzel wrote:
John Brant wrote:
INSTEAD OF
Essentially, the names are backwards to me: instead of
VisitorPluggable, I
prefer PluggableVisitor; instead of VisitorRendererHtml, I prefer
HtmlRenderingVisitor; etc. I believe this was one of Kent's patterns.
Anyway, there are some other classes besides the visitors with the
reversed
class names (e.g., LinkExternal).
Yes the names are backwards but this is probably not
justified.
Yes the names are backwards but this is probably justified.
The more general thing comes first and then the
specific thing.
(noun then adjective).
If I search for 'Visitor' I get the list of visitors to choose from.
So I do not think it is worth the effort of changing the names
to conform to English word order.
Hannes Hirzel
7694
days inactive
7696
days old
5 comments
4 participants
participants (4)
-
ducasse -
Hannes Hirzel -
John Brant -
Lukas Renggli