8 Oct
2003
8 Oct
'03
2:06 a.m.
From: Lukas Renggli [mailto:renggli@student.unibe.ch]
I was wondering how to escape characters... How about using double
characters (e.g., ** for a *)?
*) You can't save the Syntax page after you
edit it. This occurs in VW
also.
It appears that it is interpreting the "*" inside the
"<code>*</code>".
Yeah, that is a know problem: I build the parse-tree manually, because
one would need to escape all the special characters like *, [, etc.
using &xxx; Right now this is not on top of my to-do-list, but I will
fix that some time. *) When you
have an exception handler, the exception block shouldn't
just
return since that isn't legal ANSI Smalltalk. For example, instead of
having
"[self something] on: Error do: [:ex | 5]" it should be "[self
something]
on: Error do: [:ex | ex return: 5]".
Didn't know about that, the way I wrote it seemed to me more natural.
But if this is the ANSI standard, I will change it of course. I didn't notice the problem with the permissions
and could not
reproduce in VisiualWorks. Is this only a problem with #Smalltalk?
You can't reproduce it in VW -- it was in #Smalltalk. #Smalltalk treated the
behavior as undefined, which means that it was effectively resuming the
exception and the code continued to run so you would get a message saying
that you didn't have the permissions to do something and then it would show
you want you weren't supposed to do.
*) Does the
#nextVersionBecome: message ever get sent where the
argument's
class isn't the same as the receiver's class? I didn't see any places
where
that would happen so I changed it to be:
nextVersionBecome: aStructure
| previous |
previous := self copy.
self instanceVariableNames do: [:each | self instanceVariableNamed:
each put: (aStructure instanceVariableNamed: each)].
self version: previous version + 1.
self predecessor: previous.
^self
This version gets around having to #become: the versions.
That makes the tests pass, but unfortunately the real issue doesn't
seem to be covered by the tests. There might be links with references
to that structure anywhere within the wiki that have to be updated. The
cleanest solution (but maybe a bit slow) I can think of, would be to
write a visitor walking through the documents and all its versions of
the whole wiki and check manually all the internal links. As I have a
test case for that behavior now, it should be easy to get rid of the
one and only #become: in SmallWiki ... *) It would be
nice if the integer comparisons used #= instead of #==.
In
#Smalltalk, "1 + 2 == 3" is false since I have to use real objects for
integers.
Now I know that it is stupid to use #== when it wouldn't be needed.
When starting with the project I had a different opinion, that is why
there are still a lot of unnecessary #== in the code. I hope that I
cleaned everything now ... *) The tests
didn't test evaluating code that returns a block and then
doing
a renderOn: that block. In #Smalltalk, it just evaluates the parse
trees
instead of compiling the code so evaluated code blocks are instances of
RBFakeEvaluationBlock instead of BlockClosure. When I loaded the
initial
page, it displayed "a RBFakeEvaluationBlock" instead of the items in
the
collection.
Are you taking about code in the wiki-documents? I haven't thought
about returning blocks and don't even know what this could be useful
for? So instead of writing something like