24 Sep
2006
24 Sep
'06
9:46 a.m.
Hi Keith,
When PRChildren is empty, I am getting uneccessary
database
accesses at
every leaf node. I am sure that there are several ways of solving this
but for now I am experimenting in my image with...
I wonder where from these children are accessed? No part of the code
should directly access the children of a structure, but instead walk
over them using a visitor. Of course, I might have missed something ...
PRStructure>>#childrenDecoration removed
Note that subclasses of PRStructure might override
#childrenDecorationClass to use a completely different decoration for
children.
and an access interface defined for children...
#addChild:
#childAt:
#childAt:ifAbsent:
#childAt:ifPresent:
#childrenIncludes:
#removeChild:
I don't see why this would help. As far as I see none of my code uses
any of this functionality directly.
Such that if there are no children then no PRChildren
decoration is
added into the structure's decorations.
I don't have many accessors of childrenDecoration in my image, except
for the tests. Where/When are unnecessary decorations created?
would this change be acceptable?
It is not the way Pier is designed. Compared to SmallWiki I wanted to
factor out all the behavior related to children to a different
(pluggable) object.
Lukas
--
Lukas Renggli
http://www.lukas-renggli.ch