Thanks,
John
On Jul 15, 2009, at 8:16 AM, Mariano Martinez Peck wrote:
On Wed, Jul 15, 2009 at 1:48 AM, John Borden <jborden23(a)mac.com> wrote:
Hi Mariano,
Today, I tried to reproduce the problem with Pier 1.2, and it returned
results without error. The advanced search is a child of PRSearchWidget,
the idea was to have all of the searches work from the current structure,
not from root. Can you send some detail on how the search is embedded or
anything?
Yes. I did this steps:
1) downloaded Pier 1.2
2) Go to
3) add command and create a "Pier search" component
4) Go to component search, and search for "new" and you will get two
results. I don't embed it anywhere.
5)
Now. See PRSearchWidget>>findItems
^ (self context root fullTextSearch subString: self searchText)
contents
And change it to (as it is in your advanced search):
findItems
^ (self context structure fullTextSearch subString: self searchText)
contents
6) Try search again with "new" and you won't find anything.
So, is this expected? It make more sense to be to search from root so
that to search in all the site.
Best,
Mariano
Personally, I think the advanced search looks
sharp combined with a
lightbox - see
http://smallwiki2.seasidehosting.st/seaside/pier/Changes%20for%20Pier/Advan…
Thanks,
John
On Jul 13, 2009, at 11:17 PM, Mariano Martinez Peck wrote:
John Borden: I found a problem with this advanced search addon. Take a
clean Pier image. (you can use 1.2 if you want). Add a simple search widget
and test it (with results). It will work. Then download package
Pier-SW2-Sw1Features and try to search again. You will see that it doesn't
work anymore :(
I debug it a bit and I found a problem because the package
Pier-SW2-Sw1Features changes:
PRSearchWidget>>findItems
"Changed code to replace 'structure' in the below, it was originally
root."
^ (self context root fullTextSearch subString: self searchText)
contents
to:
PRSearchWidget>>findItems
"Changed code to replace 'structure' in the below, it was originally
root."
^ (self context structure fullTextSearch subString: self searchText)
contents
As you can see it change from self context root to self context
structure. If i change my code by hand and put again root, simple search
starts to work again.
Is this correct? should I commit this fix ? how this affect to the
advanced search ?
Thanks!
Mariano
On Wed, Apr 15, 2009 at 11:48 PM, Mariano Martinez Peck <
marianopeck(a)gmail.com> wrote:
>
>
> On Wed, Apr 15, 2009 at 10:50 PM, John Borden <jborden23(a)mac.com>wrote;wrote:
>
>> Mariano,There is a first draft of the Advanced Search in
>> Pier-SW2-AdvancedSearch in the Pier Addons. A short description of it is
>> at:
>>
>>
http://smallwiki2.seasidehosting.st/seaside/pier/Changes+for+Pier/Advanced+…
>>
>
> Nice men!!! Very good job. Very useful. I could perfectly added to my
> website.
>
> I have some ideas/notes/questions:
>
> 1) In your example:
>
http://smallwiki2.seasidehosting.st/seaside/pier/Changes+for+Pier/Advanced+…
> you have the word "search" as an example. When you do focus there, this is
> removed. This doesn't happen to me with your widget. I have there what I
> searched the last time. Wouldn't be better to put "search" as an
example,
> every time I render that component ?
>
> 2) In your example, the search is an ajax search. I think it is
> PRAjaxSearchWidget. But, in your code, PRAdvancedSearchWidget is a subclass
> of PRSearchWidget. I like more the ajax's one.
>
> 3) Suppose I want the final/normal user to customize the search: max
> items, filters, and so on. Should the user have access to "edit" command
of
> my search component? or It would be better to let customize this in the
> advanced search in the same way as "case sensitive" or "case
insensitive"
> ???
>
>
>
>>
>> The picture on that page shows how it could be used in a lightbox. It
>> was really neat seeing the background page change as the links were clicked,
>> however it crashed after 2 clicks with a Seaside Walkback
>> (WAComponentsNotFoundError: Components not found while processing
>> callbacks:). I implemented #children in all sorts of ways, but never got it
>> to work right.
>>
>>
>
>> Let us know if you can get it to work.
>>
>
> I could reproduce the error. I will try to find the problem. However,
> know I am still very newbie with Pier and a a little newbie with Seaside
> haha.
>
>
>> Thanks,
>>
>
> No, thanks to you. Thanks for your work and for sharing this to us.
>
> Cheers,
>
> Mariano
>
>
>
>> John
>>
>
>
>>
>> On Apr 2, 2009, at 10:18 AM, Cédrick Béler wrote:
>>
>> I just had a quick look...
>>
>> It seems they refer to an inst var "creation" in PRStructure... Does
>> such a var existed before ?
>>
>> Thanks
>>
>> 2009/4/1 Mariano Martinez Peck <marianopeck(a)gmail.com>om>:
>>
>>
>>
>> On Sat, Mar 28, 2009 at 10:13 PM, John Borden <jborden23(a)mac.com>
>> wrote:
>>
>>
>> All,
>> Is anyone aware of an advanced search for pier, such as case
>> sensitive,
>> boolean (this phrase and/or/but-not that phrase), date related, etc?
>> If
>> not, I'll start looking into adding it to the PRFullTextSearch class.
>> Thanks,
>> John
>>
>>
>> Yes. Please do!!! This would be very useful for an application I am
>> making
>> now. So, consider me as a beta tester if you want :)
>>
>> Cheers,
>>
>> Mariano
>>
>>
>> _______________________________________________
>> SmallWiki, Magritte, Pier and Related Tools ...
>>
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>>
>>
>>
>>
>> _______________________________________________
>> SmallWiki, Magritte, Pier and Related Tools ...
>>
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>>
>>
>>
>>
>> --
>> Cédrick
>>
>>
>> _______________________________________________
>> SmallWiki, Magritte, Pier and Related Tools ...
>>
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>>
>>
>>
>> _______________________________________________
>> Magritte, Pier and Related Tools ...
>>
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>>
>
>
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
_______________________________________________
Magritte, Pier and Related Tools ...
_______________________________________________
Magritte, Pier and Related Tools ...