14 Sep
2014
14 Sep
'14
8:13 p.m.
Hi Esteban,
I think the report class is a good improvement to Magritte. I opened a development version
on Magritte where I also want to feed back some (backwards compatible) improvements I
build for QC Magritte back into Magritte. As Stephan pointed out: yes, the report class
was one of them. The major improvement for 3.2 I have in mind is putting builders into
Magritte.
So I would say: please put this change into the Magritte repository, and put the version
into 3.2.
Regards,
Diego
On 12 Sep 2014, at 15:45, Esteban A. Maringolo <emaringolo(a)gmail.com> wrote:
Hi Stephan,
I know I can subclass and modify what I need, in fact I did that.
Regarding whether to use QC or not I'm always hesitating, because,
given your two examples, I don't know which one does what. It has no
methods or class' comments.
I seems you hit many Magritte "limitations" before, and has been
"extending" it with QC, but even after watching the last ESUG
presentation QC it is unfathomable to me as a whole.
Regards!
Esteban A. Maringolo
2014-09-12 7:13 GMT-03:00 Stephan Eggermont <stephan(a)stack.nl>nl>:
We have a few different subclasses doing
QCToManyComponnet>>buildReport
| retVal |
self magritteDescription startEditAll ifTrue: [ self editAll ].
retVal := (self reportClass rows: self value description: self reference)
sortEnabled: self magritteDescription isOrdered not;
yourself.
retVal columns do: [ :each |
each mementoCache: self cache.
(each isKindOf: MADescribedColumn) ifTrue: [
self addColumnCommandsTo: each.
each filter: true ] ].
retVal showFilter: self magritteDescription showFilter.
retVal doubleClickCommand: self editCommand.
^retVal
QCQueriedToManyComponent>>buildReport
| retVal shown |
retVal := super buildReport.
shown := self resultsDescription shownColumns.
retVal columns do: [ :column |
| desc |
desc := shown detect: [ :each | column magritteDescription = each ]
ifNone: [ nil ].
column visible: desc notNil.
desc ifNotNil: [ column magritteDescription priority: desc priority ] ].
retVal columns sort: [ :a :b | a < b ].
^retVal
TBSMagritteOneToManyComponent>>buildReport
^ (TBSMagritteReport rows: self value description: self reference)
sortEnabled: self magritteDescription isOrdered not;
yourself
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki