21 Dec
2006
21 Dec
'06
11:05 p.m.
On 2006-12-21, at 14:32, Lukas Renggli wrote:
The problem here is that this will turn the
Magritte-Core package
dependent on the Seaside package, because it already defines
#displayString. Otherwise I don't see a problem to adopt this in
the Squeak Code.
I guess the question that would need answering is, how many users
would be affected by having load the Seaside package first? In the
case of the VW port, I pre-req Seaside anyway. What how many Squeak
users are _not_ using Seaside with Magritte? I think both of those
users could live with having to load the Seaside code as well. :{)
There are two uses of SystemChangeNotifier, they
should be probably
moved to the MACompatiblity class.
Ah, yes, the "Incompatibility" class, as I call it. :{) That, and
the MADistribution class came over to VW with just about nothing
working. I got the test for #referenceStream: working, but only by
changing the test code. I have my doubts as to whether the block-
related stuff will really work properly as well, but I don't think
it's a big concern for the Seaside-based users that will be the
biggest (only) consumers in VW.
1. MAAutoSelectorAccessorTest: this one is only needed
to prevent
from marking the test-package dirty as this tests adds/removes i-
vars/accessors.
I don't believe this is an issue in VW/StORE - it would be in an ENVY
environment. I modified the code to just pass the message send on to
super.
There were some concerns in the beginning that
rebuilding those
descriptions over and over again is very costly, therefor I added
the caching. I don't know if this is still relevant. Probably it
hurts more than it helps, but we have to check.
Uh oh, the evil spectre of premature optimization rears its ugly head!
For development purposes, I can live with manually flushing the cache
as needed. For a runtime environment, my personal preference is to
use packaged images anyway, so I find it hard to worry too much about
the impact of code changes. If we document a need to flush the
cache, I think that should be sufficient, unless someone more into
the internals of VW browsers has a better idea.
I think this change was introduced by the latest
change of
Philippe, maybe he can have a look?
I'll do another port once we've figured out this one - I've found a
few other little things I'd like to clean up anyway.
--
============================================================
Thomas Koschate
--
============================================================
Thomas Koschate +1 416.716.5949
koschate(a)omasko.com FAX: +1 905.451.9268
PGP Key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x4659702E