27 Nov
2003
27 Nov
'03
8:18 a.m.
This doesn't bother me -- I didn't learn
visitor from the DP book.
However,
if it makes it clearer for others, then you should do it.
Yes especially because lot of people will learn Smalltalk based on
SmallWiki :)
Roel here as 16 projects based on SmallWiki. So your code will be the
first one
for a lot of newbies :)
- Another
thing about the visitors are their class-names. If I
remember
correctly you told me in one of your reviews that you dislike those
names. So far I did not change anything, but when doing a visitor
refactoring I would like to do everything at once. What class-naming
would you prefer exactly?
Essentially, the names are backwards to me: instead of
VisitorPluggable, I
prefer PluggableVisitor; instead of VisitorRendererHtml, I prefer
HtmlRenderingVisitor; etc. I believe this was one of Kent's patterns.
Anyway, there are some other classes besides the visitors with the
reversed
class names (e.g., LinkExternal).
John Brant