Hi,
I have started with SmallWiki 0.9.20. The first steps of porting
are done.
Lukas Renggli wrote:
when porting
SmallWiki 0.9.19 to squeak I have found some points that
could eventually be solved better.
- #displayString should be #asString ?!?
as far as I know #displayString and #printString are ANSI standard, but
not #asString, e.g. in VisualWorks there is no #asString. The Purple
Book only describes #displayString and #printString too.
OK I put a #displayString into Object.
-
#internal_templates contains $_
Indeed, this is not portable at all. #'internal_templates' should work,
but this looks ugly. What I did here was to prefix with some special
string to avoid conflicts with user-defined properties. The next time I
publish an updated version it will be renamed to #internalTemplate.
This is also in #internal_stylesheet
I changed this to #internalTemplates and #internalStylesheet.
What I did was:
- put 'SW' as prefix to every SmallWiki class.
- change Timestamp to TimeStamp
- change #raiseSignal: to #signal:.
- I had to paste the following Methods in by hand:
- HtmlWriteStream class>>defaultEscapeTable
- ParserTests>>wikiText
- ParserTests>>docText
- ParserTestsOld>>defaultWikiChars
- ParserTestsOld>>testDefaultWikiChars
because Rosetta produced special characters which saxon
didn't know.
- I had to compile a new Parser and Scanner.
- The VW Set can #add: nil without an Exception.
I added #silentAdd:.
- The #resourcesFor* Methods in ParserTests are bad, because
they use the class name which I have prefixed with 'SW'.
I did a hack to solve this.
- I didn't find a class for Base64EncodingReadStream.
For now I took ReadStream.
- change #sameCharacters: to #charactersExactlyMatching:
For today this is the result:
green Tests
- CacheTests
- ExtensionTests
- ResponseTests
- StorageTests
- TemplateTests
yellow Tests
- ParserTests
- PropertyTests
- RequestTests
- SecurityTests
redTests
- DocumentTests
- ParserTestsOld
- ServerTests
- StructureTests
When all tests are green I will post a changeset.
Further comments?
regards
Chris Burkert
--
http://www.chrisburkert.de/