26 Nov
2003
26 Nov
'03
3:33 p.m.
From: owner-smallwiki(a)iam.unibe.ch
[mailto:owner-smallwiki@iam.unibe.ch]
On Behalf Of Lukas Renggli
Btw, talking about visitors:
- I basically use the same naming conventions as the refactoring
browser for the messages #accept:, #acceptFolder:, #visit:, etc.
Several people were complaining that this does not match the
suggestions of the book Smalltalk design-pattern companion and was
confusing them. I don't really care what approach to take, but would be
interested in your opinion?
This doesn't bother me -- I didn't learn visitor from the DP book. However,
if it makes it clearer for others, then you should do it.
- Another thing about the visitors are their
class-names. If I remember
correctly you told me in one of your reviews that you dislike those
names. So far I did not change anything, but when doing a visitor
refactoring I would like to do everything at once. What class-naming
would you prefer exactly?
Essentially, the names are backwards to me: instead of VisitorPluggable, I
prefer PluggableVisitor; instead of VisitorRendererHtml, I prefer
HtmlRenderingVisitor; etc. I believe this was one of Kent's patterns.
Anyway, there are some other classes besides the visitors with the reversed
class names (e.g., LinkExternal).
John Brant