Looks cool.<div><br></div><div>- I would put the drop-down list with classes on top, seem to be strange to read from the bottom.</div><div>- Editing a production does not seem to work. The method definition disappears and graph and example are broken.<br>
<div>- I missed production protocols already in the old browser.</div><div>- The start production is somehow missing in the list.</div><div>- Also useful would be a static tree with the references in the leaves</div><div>
- Inspecting a parse result inspects a GLMMultiValue.</div><div>- There should be a button to expand the debug trace, at least to a given level.</div><div><br></div><div>Below my suggestion for the remove-production refactoring:</div>
<div><br></div><div><div>remove: aSymbol in: aClass</div><div><span class="Apple-tab-span" style="white-space:pre">	</span>| references |</div><div><span class="Apple-tab-span" style="white-space:pre">	</span>references := aClass new productionNames values</div>
<div><span class="Apple-tab-span" style="white-space:pre">		</span>intersection: (aClass whichSelectorsReallyRead: aSymbol).</div><div><span class="Apple-tab-span" style="white-space:pre">	</span>references notEmpty ifTrue: [</div>
<div><span class="Apple-tab-span" style="white-space:pre">		</span>(self confirm: &#39;The following production(s) refer to &#39; , aSymbol printString , &#39;:&#39; , String cr , ((references collect: [ :each | each printString ]) fold: [ :a :b | a , &#39;, &#39; , b ]) , &#39;. Really delete?&#39;)</div>
<div><span class="Apple-tab-span" style="white-space:pre">			</span>ifFalse: [ ^ self ] ].</div><div><span class="Apple-tab-span" style="white-space:pre">	</span>(aClass instVarNames includes: aSymbol)</div><div><span class="Apple-tab-span" style="white-space:pre">		</span>ifTrue: [ aClass removeInstVarNamed: aSymbol ].</div>
<div><span class="Apple-tab-span" style="white-space:pre">	</span>(aClass selectors includes: aSymbol)</div><div><span class="Apple-tab-span" style="white-space:pre">		</span>ifTrue: [ aClass removeSelector: aSymbol ]</div>
</div><div><br></div><div>Lukas</div><div><br><div class="gmail_quote">On 6 December 2011 22:53, Tudor Girba <span dir="ltr">&lt;<a href="mailto:tudor@tudorgirba.com">tudor@tudorgirba.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word">Hi,<div><br></div><div>I just wanted to let you know that I started to rework the PetitParser browser.</div><div><br></div><div>There are several things that have changed:</div><div><br></div>
<div>- it is modular, currently being formed of 3 distinct browsers. To give them a try (I also attached a couple of screenshots):</div><div>PPAllParsersBrowser open.</div><div>PPParserBrowser openOn: PPArithmeticParser.</div>
<div>PPParserInspector openOn: PPArithmeticParser new.</div><div><br><div>- it only relies on the Glamour mechanisms without state in the implementation code. This was more of a validation that the engine is expressive enough</div>
<div><br></div><div>- it has a slightly different layout</div><div><br></div><div>- the Mondrian map can be used as a navigation, so clicking on a node will focus the browser on that production.</div><div><br></div><div>- it uses a tree widget for the debugger so we can scale for large debugging traces</div>
<div><br></div><div><br></div><div>What is still to do:</div><div>- install the associated instance variable for each newly created production.</div><div>- introduce parser renaming refactoring. This would entail triggering both a method and an instance var rename.</div>
<div>- add the possibility to remove a production. This would entail removing a method and the corresponding instance var.<br>- make the morph graph view interactive.</div><div>- add a new grammar class.</div><div>- integrate tests for each production. This would involve being able to browse tests associated to a production, run, add and remove them.</div>
<div><br></div><div>If these would work, we would have a true IDE and for most parts we would not need the Smalltalk editor for building parsers.</div><div>But, I could use some help on the todos left, especially on the refactorings.</div>
<div><br></div><div><br></div><div>Cheers,</div><div>Doru</div><div><br></div><div><img height="408" width="766" src="cid:6443E0F2-B5A3-42FC-B754-20F8569E548F"><img height="408" width="766" src="cid:332956CF-93A8-4366-9BF9-985F6EEEA8A2"></div>
<span class="HOEnZb"><font color="#888888"><div>--</div><div><a href="http://www.tudorgirba.com" target="_blank">www.tudorgirba.com</a><br><br>&quot;Presenting is storytelling.&quot;<br></div><br>
</font></span></div></div><br>_______________________________________________<br>
Moose-dev mailing list<br>
<a href="mailto:Moose-dev@iam.unibe.ch">Moose-dev@iam.unibe.ch</a><br>
<a href="https://www.iam.unibe.ch/mailman/listinfo/moose-dev" target="_blank">https://www.iam.unibe.ch/mailman/listinfo/moose-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Lukas Renggli<br><a href="http://www.lukas-renggli.ch">www.lukas-renggli.ch</a><br>
</div></div>