Alexandre Bergel wrote:
Hi Ben,
I've seen you committed in the Mondrian rep about the rubber band drag and drop facilities. This is indeed an interesting feature. However, I feel a bit more work is necessary. Here are my suggestions:
- can you make sure all the Mondrian tests are green. Apparently MORoot>>resetFormCacheResursively disappeared.
Do you mean MONode>>resetFormCacheResursively which was renamed in Mondrian-Core-AlexandreBergel.79 ?
I've searched back a few Mondrian-Core mcz files and not found MORoot>>resetFormCacheResursively.
I fixed a few remaining references to this in Mondrian-Core-BenComan.80 et al.
I fixed MOLayoutTest>>testTreeLayout failure in Mondrian-Tests-BenComan.101.
There is one remaining failure that I can't work out. TestRunner cannot open a debugger on it and after inserting 'self halt' it steps through to the end of the method without a failure. Makes no sense to me. I need to leave this one to others.
- add new tests that capture your change of MOCanvas>>mouseUp: , MOCanvas>>mouseOver:, and possibly for MOCanvas>>drawOn:. Those methods are central to Mondrian, they need to be robust.
I will now start thinking about some tests for these.
Let me know how it goes. Currently the tests of Mondrian are yellow.
Cheers,
Alexandre
On 8 May 2012, at 16:42, admin@moosetechnology.org wrote:
See <http://hudson.moosetechnology.org/job/moose-latest-dev/972/>
_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev