Hi,
I just saw that the way the parent selectors are being defined was changed. In general, please announce deep changes like these on the mailing list.
If I understand correctly, the goal was to make it easier for extensions to specify the parentSelectors. This is a good goal, but there are two problems with the current solution:
1. The parentSelectors should be extensible. Right now, they are defined in one method returning a collection of strings. Instead, it would be better to have them described directly in the selector method. For example, we could have:
FAMIXType>>container
<MSEProperty: #container type: #FAMIXContainerEntity opposite: #types>
<MSEComment: 'Container entity to which this type belongs to. Container is a namespace, not a package (Smalltalk).'>
<MSEParentProperty> ^container
This would also allow us to extend existing classes with annotations that can be selectors.
2. Right now, the parentSelectors are defined on the instance side as an MSE property:
FAMIXType>>parentSelectors
<MSEProperty: #parentSelectors type: #String>
<multivalued>
^ #(container parentPackage)
This is incorrect given that they describe the type, not the instance. For example, one consequence is that now we serialize this information (check MooseModel>>testExport which fails right now). Instead, let’s go for solution from point 1.
What do you think?
Cheers,
Doru