On Tue, Sep 1, 2015 at 12:07 PM, Andrei Chis <chisvasileandrei@gmail.com> wrote:
Hi Usman,

Are you loading Moose 5.0 in Pharo 3, 4 or 5?

I'm loading it in Pharo 4.0.
 

From what I remember due to issues with black/white theme we decided to have the glamour presentation for rubric use the default theme settings.
In Moose 6 the check can be removed but not the settings of the setting of the textColor:

Is there an issue you are having because of this?

Yes. When I apply some text coloration and display the text with Rubric presentation, it is overwritten with default text color.
Is there any other text presentation using Rubric that might cover my use case?
 

Cheers,
Andrei

On Mon, Aug 31, 2015 at 4:29 PM, Usman Bhatti <usman.bhatti@gmail.com> wrote:
Hi,

There seems to be a problem with simple the rubric presentation in Moose 5.0. TextColor attributes are overridden with default text color from the theme when the morph is created.

There is a flag in the morph creation code that says that the code needs reviewing in Pharo 4.0. So removing two lines below after the flag resolve this issue:

GLMMorphicRubricTextRenderer>>morph
|morph|
morph := RubScrolledTextMorph new
getSelectionSelector: #primarySelectionInterval;
model: textModel;
color: Smalltalk ui theme backgroundColor;
textFont: StandardFonts defaultFont;
yourself.
self flag: 'Temporary solution until Moose moves to Pharo 4'.
(Smalltalk ui theme class canPerform: #textColor) ifTrue: [ 
morph textColor: Smalltalk ui theme  textColor ].
^ morph

Should I commit a fix removing the flagged lines? Should I create a new branch for the fix?


_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev