On Mon, Sep 14, 2015 at 12:55 PM, Tudor Girba <tudor@tudorgirba.com> wrote:
Sounds good. But, if we add it to the MooseModel, then we will not need the instance variable, because it will be added in the pool of entities.

Agreed. That information is redundant and we can remove Instance variable. So, the getter becomes

MooseModel>>sourceLanguage
<MSEProperty: #sourceLanguage type: #FAMIXSourceLanguage>
<MSEComment: 'Source of the Language to which the model corresponds'>
^ self
propertyNamed: name
ifAbsentPut: [ self allSourceLanguages detect: [ :each | each isAttached not ] ifNone: [ FAMIXUnknownSourceLanguage new ] ]

I'll do this change.
 

Doru

On Mon, Sep 14, 2015 at 11:49 AM, Usman Bhatti <usman.bhatti@gmail.com> wrote:
Hi,

I propose to change this:

MoosModel>>sourceLanguage: aSymbol
^sourceLanguage := aSymbol

by:

MoosModel>>sourceLanguage: aSourceLanguage
sourceLanguage := aSourceLanguage.
        sourceLanguage mooseModel: self

So, that we don't have to remember to add manually the source language to the model.

Is it ok to do this change?

usman


_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev