I checked and it fixes the debugger + the glamour test.
On Fri, Jul 4, 2014 at 10:32 AM, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Solved!
a problem with lastClickedMorph in the listManager (lastClickedMorph is not allways the last clicked morph, but this is another matter ;))
Can you pound on the .5 slice for 13422 ?
Thierry
Le 04/07/2014 09:45, Goubier Thierry a écrit :
Le 04/07/2014 08:00, Tudor Girba a écrit :
Thanks. It seems to work the same as the one before from the point of
view of Glamour.
However, I noticed a strange difference in the debugger. Try this:
- Do "1/0"
- In the debugger, select the first entry from the top of the stack
- Then press down once => it works fine
- Then press down again => it goes up!
(this behavior is reproducible with the version 3 of your slice as well)
The bug is a bit more complex. Upon opening the debugger, the first down
keypress doesn't do anything, the second one goes one step down (and the
third one goes one step up :)).
Thierry
I do not know what causes it. Andrei, could you take a look? I do not
have time to look at it too deeply right now.
Cheers,
Doru
On Fri, Jul 4, 2014 at 7:25 AM, GOUBIER Thierry <thierry.goubier@cea.fr
<mailto:thierry.goubier@cea.fr>> wrote:
Hi Doru,
can you test the new slice for 13422 (.4) ? I made a small semantic
change to the way the model update the selection after a list
update. I haven't seen anything wrong after loading it in Moose
(including with the debugger).
Thierry
------------------------------------------------------------------------*Objet :* [Moose-dev] Re: Playground and Shortcuts
*De :* moose-dev-bounces@iam.unibe.ch
<mailto:moose-dev-bounces@iam.unibe.ch>
[moose-dev-bounces@iam.unibe.ch
<mailto:moose-dev-bounces@iam.unibe.ch>] de la part de Tudor Girba
[tudor@tudorgirba.com <mailto:tudor@tudorgirba.com>]
*Envoyé :* jeudi 3 juillet 2014 22:34
*À :* Moose-related development
<mailto:tudor@tudorgirba.com>> wrote:
I am testing right away.
Doru
On Thu, Jul 3, 2014 at 10:20 PM, GOUBIER Thierry
<thierry.goubier@cea.fr <mailto:thierry.goubier@cea.fr>> wrote:<mailto:moose-dev-bounces@iam.unibe.ch>
Normally solved with the latest slice:
SLICE-Issue-13422-Image-crashes-because-an-open-Nautilus-browser-hangs-onto-many-objects-while-code-is-being-loaded-ThierryGoubier.3.
Bug was: Wrong selection update loop while cleaning the
listManager on update.
I also added a real delete for the removed morphs during
update.
I won't integrate yet, I'd like to explore things about the
selection while updating mechanism, and the Moose image is
hard to use on my netbook.
Can you test if this solves all the problems you could see
with trees and lists? I checked that it solved the debugger
and the test case issues.
Thierry
________________________________________
De : moose-dev-bounces@iam.unibe.ch
[moose-dev-bounces@iam.unibe.ch
<mailto:moose-dev-bounces@iam.unibe.ch>] de la part de> <mailto:thierry.goubier@cea.fr
GOUBIER Thierry
Envoyé : jeudi 3 juillet 2014 17:26
À : Moose-related development
Objet : [Moose-dev] Re: Playground and Shortcuts
Ok. I'll look into that later today, have to pick up the
kids.
So far, so good. Update is correct, selected element is
removed but is
kept as expanded (because of the select, I guess), but then
it seems to
be reintroduced in the tree.
Working out of the test case Stephan pointed out.
Thierry
Le 03/07/2014 16:58, Tudor Girba a écrit :
> 30851 already contains the problematic issue.
>
> Doru
>
>
>
> On Thu, Jul 3, 2014 at 4:50 PM, Goubier Thierry
<thierry.goubier@cea.fr <mailto:thierry.goubier@cea.fr>
<mailto:Moose-dev@iam.unibe.ch
<mailto:thierry.goubier@cea.fr>>> wrote:
>
> Ok.
>
> Where is the configurationOfGlamour? The current
Moose5.0 beta image
> in the pharo launcher is on 30851.
>
> Thierry
>
> Le 03/07/2014 16:45, Tudor Girba a écrit :
>
> Or that Glamour uses an internal API that it
should not :)
>
> Doru
>
>
> On Thu, Jul 3, 2014 at 4:41 PM, Stephan Eggermont
> <stephane@xs4all.nl <mailto:stephane@xs4all.nl>
<mailto:stephane@xs4all.nl <mailto:stephane@xs4all.nl>>
> <mailto:stephane@xs4all.nl
<mailto:stephane@xs4all.nl> <mailto:stephane@xs4all.nl
<mailto:stephane@xs4all.nl>>>> wrote:
>
> I can confirm it is the 13422 fix that is
broken/incomplete
>
> Stephan
>
_________________________________________________
> Moose-dev mailing list
> Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch>
<mailto:Moose-dev@iam.unibe.ch
<mailto:Moose-dev@iam.unibe.ch>>
> <mailto:Moose-dev@iam.unibe.ch
<mailto:Moose-dev@iam.unibe.ch>
<mailto:Moose-dev@iam.unibe.ch
<mailto:Moose-dev@iam.unibe.ch>>__>
> https://www.iam.unibe.ch/__mailman/listinfo/moose-dev
>
<https://www.iam.unibe.ch/mailman/listinfo/moose-dev>
>
>
>
>
> --
> www.tudorgirba.com <http://www.tudorgirba.com>
<http://www.tudorgirba.com>
> <http://www.tudorgirba.com>
>
>
> "Every thing has its own flow"
>
>
> _________________________________________________
> Moose-dev mailing list
> Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch>
<mailto:Moose-dev@iam.unibe.ch
<mailto:Moose-dev@iam.unibe.ch>>
> https://www.iam.unibe.ch/__mailman/listinfo/moose-dev
>
<https://www.iam.unibe.ch/mailman/listinfo/moose-dev>
>
>
> --
> Thierry Goubier
> CEA list
> Laboratoire des Fondations des Systèmes Temps Réel
Embarqués
> 91191 Gif sur Yvette Cedex
> France
> Phone/Fax: +33 (0) 1 69 08 32 92
<tel:%2B33%20%280%29%201%2069%2008%2032%2092>
> <tel:%2B33%20%280%29%201%2069%2008%2032%2092> / 83 95
> _________________________________________________
> Moose-dev mailing list
> Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch>
> Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch>
<mailto:Moose-dev@iam.unibe.ch>>
> https://www.iam.unibe.ch/__mailman/listinfo/moose-dev
> <https://www.iam.unibe.ch/mailman/listinfo/moose-dev>
>
>
>
>
> --
> www.tudorgirba.com <http://www.tudorgirba.com>
<http://www.tudorgirba.com>
>
> "Every thing has its own flow"
>
>
> _______________________________________________
> Moose-dev mailing list
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
--
Thierry Goubier
CEA list
Laboratoire des Fondations des Systèmes Temps Réel Embarqués
91191 Gif sur Yvette Cedex
France
Phone/Fax: +33 (0) 1 69 08 32 92
<tel:%2B33%20%280%29%201%2069%2008%2032%2092> / 83 95_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch>Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com <http://www.tudorgirba.com>
"Every thing has its own flow"
--Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch>
www.tudorgirba.com <http://www.tudorgirba.com>
"Every thing has its own flow"
_______________________________________________
Moose-dev mailing list
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com <http://www.tudorgirba.com>
"Every thing has its own flow"
_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
Thierry Goubier
CEA list
Laboratoire des Fondations des Systèmes Temps Réel Embarqués
91191 Gif sur Yvette Cedex
France
Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev