Subclassing is not really an option. Roassal is a core component that should remain small.

But, let's talk specifics. For example, defining the colorBlock: is a global action. Thus, if I want to define the color for multiple types of nodes I have to use an if in there. This is less ideal.

The alternative would be to use the same pattern that is used in the MondrianBuilder and apply the color to every nodes: instruction. In this way we could handle multiple node types without any ifs.

The same should be valid for every customization in the treemap.

Cheers,
Doru







On Fri, Nov 15, 2013 at 8:09 AM, Roberto Minelli <roberto.minelli@usi.ch> wrote:
Well,

We could discuss about it, also with Alex, for example.

One thing which is possible is to subclass the builder and extend it with new features, such that the original code will be consistent with its behavior.

Cheers,
Roby

On Nov 15, 2013, at 7:53 AM, Tudor Girba <tudor@tudorgirba.com> wrote:

> Hi,
>
> Ok. I might give it a try but that will imply that some of the existing code will have a different behavior because it is too restrictive in the way it is now.
>
> Cheers,
> Doru
>
>
> On Fri, Nov 15, 2013 at 7:24 AM, Roberto Minelli <roberto.minelli@usi.ch> wrote:
> Hi Doru,
>
> Happy that you played with my ROTreeMapBuilder!
>
> I’d be interested to extend it, but not anytime soon.
> At the moment the tree map builder suits my needs and I am focusing on using it on my data ;)
>
> Cheers,
> Roby
>
> On Nov 15, 2013, at 6:29 AM, Tudor Girba <tudor@tudorgirba.com> wrote:
>
> > Hi,
> >
> > I played a bit with the ROTreeMapBuilder, and there are two things that came to mind and that would be nice to extend. I opened some issues:
> >
> > - Support for multiple types of nodes.
> > https://code.google.com/p/moose-technology/issues/detail?id=1002
> >
> > - Default weight should be 1.
> > https://code.google.com/p/moose-technology/issues/detail?id=1003
> >
> > - Circular treemap
> > https://code.google.com/p/moose-technology/issues/detail?id=1004
> >
> > @Roberto: Would you be interested in working on something like this?
> >
> > Cheers,
> > Doru
> >
> > --
> > www.tudorgirba.com
> >
> > "Every thing has its own flow"
> > _______________________________________________
> > Moose-dev mailing list
> > Moose-dev@iam.unibe.ch
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
> _______________________________________________
> Moose-dev mailing list
> Moose-dev@iam.unibe.ch
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
>
> --
> www.tudorgirba.com
>
> "Every thing has its own flow"
> _______________________________________________
> Moose-dev mailing list
> Moose-dev@iam.unibe.ch
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--
www.tudorgirba.com

"Every thing has its own flow"